Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-addon-api
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.6.3
Choose a base ref
...
head repository: nodejs/node-addon-api
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.7.0
Choose a head ref
  • 19 commits
  • 25 files changed
  • 10 contributors

Commits on Apr 4, 2019

  1. doc: refer to TypedArray and ArrayBuffer from Array

    Add a blurb to the `Napi::Array` documentation that refers readers to
    `Napi::TypedArray` and `Napi::ArrayBuffer` for using arrays with large
    amounts of data.
    
    PR-URL: #465
    Reviewed-By: Michael Dawson <[email protected]>
     Reviewed-By: Nicola Del Gobbo <[email protected]>
    Gabriel "_|Nix|_" Schulhof authored and mhdawson committed Apr 4, 2019
    Configuration menu
    Copy the full SHA
    36863f0 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2019

  1. 1 Configuration menu
    Copy the full SHA
    a3b4d99 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2019

  1. Fix link

    PR-URL: #481
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: NickNaso <[email protected]>
    mildsunrise authored and mhdawson committed May 17, 2019
    Configuration menu
    Copy the full SHA
    3ad5dfc View commit details
    Browse the repository at this point in the history
  2. Use Value::IsEmpty to check for empty value

    PR-URL: #478
    Reviewed-By: Anna Henningsen <[email protected]>
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    NickNaso authored and mhdawson committed May 17, 2019
    Configuration menu
    Copy the full SHA
    e1cf9a3 View commit details
    Browse the repository at this point in the history
  3. Little fix on code example

    PR-URL: #470
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Hitesh Kanwathirtha <[email protected]>
    NickNaso authored and mhdawson committed May 17, 2019
    Configuration menu
    Copy the full SHA
    aaea55e View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2019

  1. string.md: Document existing New(env, value, length) APIs

    PR-URL: #486
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: NickNaso <[email protected]>
    tux3 authored and mhdawson committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    f633fbd View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2019

  1. AsyncWorker: introduce Destroy() method

    `AsyncWorker` contained the assumption that instances of its subclasses
    were allocated using `new`, because it unconditionally destroyed
    instances using `delete`.
    
    This change replaces the call to `delete` with a call to a protected
    instance method `Destroy()`, which can be overridden by subclasses.
    This ensures that users can employ their own allocators when
    creating `AsyncWorker` subclass instances because they can override
    the `Destroy()` method to use their deallocator of choice.
    
    Re: #231 (comment)
    PR-URL: #488
    Reviewed-By: Michael Dawson <[email protected]>
    Gabriel Schulhof committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    3b6b9eb View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2019

  1. src: fix objectwrap test case

    Refs: #485
    
    The test case was relyingon the ordering of
    "for in" which is not guarranteed as per
    https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...in
    
    Update the testcase to check in an way that does
    not depend on ordering.
    
    PR-URL: #495
    Refs: #485
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: NickNaso <[email protected]>
    mhdawson committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    ab7d8fc View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2019

  1. Added test for bool operator

    PR-URL: #490
    Reviewed-By: Michael Dawson <[email protected]>
    NickNaso authored and mhdawson committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    a0cac77 View commit details
    Browse the repository at this point in the history
  2. AsyncWorker: make callback optional

    `AsyncWorker` assumed that after work is complete,  a JavaScript
     callback would need to execute.
    
    This change removes the restriction of specifying a `Function` callback,
    and instead replaces it with an `Env` parameter. Since the purpose of
    `receiver` was for the `this` context for the callback, it has also been
    removed from the constructors.
    
    Re: #231 (comment)
    
    PR-URL: #489
    Reviewed-By: Michael Dawson <[email protected]>
    KevinEady authored and mhdawson committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    b2b0812 View commit details
    Browse the repository at this point in the history
  3. Use curly brackets to include node_api.h

    PR-URL: #493
    Reviewed-By: Michael Dawson <[email protected]>
    NickNaso authored and mhdawson committed Jun 18, 2019
    Configuration menu
    Copy the full SHA
    1fb540e View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2019

  1. Implement ThreadSafeFunction class

    This PR is implementing ThreadSafeFunction class wraps
    napi_threadsafe_function features.
    
    FYI, the test files that included in this PR have come from Node.js
    repo[1]. They've been rewritten based on C   and node-addon-api.
    
    [1] https://github.com/nodejs/node/tree/e800f9d/test/node-api/test_threadsafe_function
    
    PR-URL: #442
    Fixes: #312
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: Gabriel Schulhof <[email protected]>
    romandev authored and Gabriel Schulhof committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    0a90df2 View commit details
    Browse the repository at this point in the history
  2. macros: create errors fully namespaced

    Errors in `NAPI_THROW()` and Co. were being thrown as `Error:New(...)`
    but they should be thrown as `Napi::Error::New(...)` because the former
    assumes that the user has opted to declare `using namespace Napi;`.
    
    PR-URL: #506
    Reviewed-By: Nicola Del Gobbo <[email protected]>
    Reviewed-By: Gus Caplan <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    Gabriel Schulhof committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    c32d7db View commit details
    Browse the repository at this point in the history
  3. doc: ClassPropertyDescriptor example

    PR-URL: #507
    Reviewed-By: Nicola Del Gobbo <[email protected]>
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    ross-weir authored and Gabriel Schulhof committed Jul 10, 2019
    Configuration menu
    Copy the full SHA
    cab3b1e View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2019

  1. doc: document ThreadSafeFunction (#494)

    * doc: document ThreadSafeFunction
    
    PR-URL: #494
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    KevinEady authored and mhdawson committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    e9fa1ea View commit details
    Browse the repository at this point in the history
  2. doc: fix minor typo

    PR-URL: #510
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: NickNaso <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    morokosi authored and mhdawson committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    ac6000d View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2019

  1. doc: add ThreadSafeFunction to main README (#513)

    PR-URL: #513
    Reviewed-By: Gabriel Schulhof <[email protected]>
    Reviewed-By: NickNaso <[email protected]>
    Reviewed-By: Michael Dawson <[email protected]>
    KevinEady authored and mhdawson committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    d9d991b View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2019

  1. AsyncWorker: add GetResult() method

    Adds an overridable `GetResult()` method, providing arguments
    to the callback invoked in `OnOK()`.
    
    Refs: #231 (comment)
    PR-URL: #512
    Reviewed-By: Michael Dawson <[email protected]>
    Reviewed-By: NickNaso <[email protected]>
    Reviewed-By: Gabriel Schulhof <[email protected]>
    KevinEady authored and mhdawson committed Jul 22, 2019
    Configuration menu
    Copy the full SHA
    717c9ab View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2019

  1. Prepare release 1.7.0

    NickNaso committed Jul 23, 2019
    Configuration menu
    Copy the full SHA
    0a1380c View commit details
    Browse the repository at this point in the history
Loading