-
Notifications
You must be signed in to change notification settings - Fork 459
Comparing changes
Open a pull request
base repository: nodejs/node-addon-api
base: 1.6.3
head repository: nodejs/node-addon-api
compare: 1.7.0
- 19 commits
- 25 files changed
- 10 contributors
Commits on Apr 4, 2019
-
doc: refer to TypedArray and ArrayBuffer from Array
Add a blurb to the `Napi::Array` documentation that refers readers to `Napi::TypedArray` and `Napi::ArrayBuffer` for using arrays with large amounts of data. PR-URL: #465 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Nicola Del Gobbo <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 36863f0 - Browse repository at this point
Copy the full SHA 36863f0View commit details
Commits on May 13, 2019
-
1
Configuration menu - View commit details
-
Copy full SHA for a3b4d99 - Browse repository at this point
Copy the full SHA a3b4d99View commit details
Commits on May 17, 2019
-
PR-URL: #481 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: NickNaso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 3ad5dfc - Browse repository at this point
Copy the full SHA 3ad5dfcView commit details -
Use
Value::IsEmpty
to check for empty valuePR-URL: #478 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e1cf9a3 - Browse repository at this point
Copy the full SHA e1cf9a3View commit details -
PR-URL: #470 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Hitesh Kanwathirtha <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for aaea55e - Browse repository at this point
Copy the full SHA aaea55eView commit details
Commits on Jun 5, 2019
-
string.md: Document existing New(env, value, length) APIs
PR-URL: #486 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: NickNaso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f633fbd - Browse repository at this point
Copy the full SHA f633fbdView commit details
Commits on Jun 11, 2019
-
AsyncWorker: introduce Destroy() method
`AsyncWorker` contained the assumption that instances of its subclasses were allocated using `new`, because it unconditionally destroyed instances using `delete`. This change replaces the call to `delete` with a call to a protected instance method `Destroy()`, which can be overridden by subclasses. This ensures that users can employ their own allocators when creating `AsyncWorker` subclass instances because they can override the `Destroy()` method to use their deallocator of choice. Re: #231 (comment) PR-URL: #488 Reviewed-By: Michael Dawson <[email protected]>
Gabriel Schulhof committedJun 11, 2019 Configuration menu - View commit details
-
Copy full SHA for 3b6b9eb - Browse repository at this point
Copy the full SHA 3b6b9ebView commit details
Commits on Jun 13, 2019
-
Refs: #485 The test case was relyingon the ordering of "for in" which is not guarranteed as per https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for...in Update the testcase to check in an way that does not depend on ordering. PR-URL: #495 Refs: #485 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: NickNaso <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ab7d8fc - Browse repository at this point
Copy the full SHA ab7d8fcView commit details
Commits on Jun 18, 2019
-
PR-URL: #490 Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a0cac77 - Browse repository at this point
Copy the full SHA a0cac77View commit details -
AsyncWorker: make callback optional
`AsyncWorker` assumed that after work is complete, a JavaScript callback would need to execute. This change removes the restriction of specifying a `Function` callback, and instead replaces it with an `Env` parameter. Since the purpose of `receiver` was for the `this` context for the callback, it has also been removed from the constructors. Re: #231 (comment) PR-URL: #489 Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b2b0812 - Browse repository at this point
Copy the full SHA b2b0812View commit details -
Use curly brackets to include node_api.h
PR-URL: #493 Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1fb540e - Browse repository at this point
Copy the full SHA 1fb540eView commit details
Commits on Jul 10, 2019
-
Implement ThreadSafeFunction class
This PR is implementing ThreadSafeFunction class wraps napi_threadsafe_function features. FYI, the test files that included in this PR have come from Node.js repo[1]. They've been rewritten based on C and node-addon-api. [1] https://github.com/nodejs/node/tree/e800f9d/test/node-api/test_threadsafe_function PR-URL: #442 Fixes: #312 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0a90df2 - Browse repository at this point
Copy the full SHA 0a90df2View commit details -
macros: create errors fully namespaced
Errors in `NAPI_THROW()` and Co. were being thrown as `Error:New(...)` but they should be thrown as `Napi::Error::New(...)` because the former assumes that the user has opted to declare `using namespace Napi;`. PR-URL: #506 Reviewed-By: Nicola Del Gobbo <[email protected]> Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Gabriel Schulhof committedJul 10, 2019 Configuration menu - View commit details
-
Copy full SHA for c32d7db - Browse repository at this point
Copy the full SHA c32d7dbView commit details -
doc: ClassPropertyDescriptor example
PR-URL: #507 Reviewed-By: Nicola Del Gobbo <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for cab3b1e - Browse repository at this point
Copy the full SHA cab3b1eView commit details
Commits on Jul 16, 2019
-
doc: document ThreadSafeFunction (#494)
* doc: document ThreadSafeFunction PR-URL: #494 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e9fa1ea - Browse repository at this point
Copy the full SHA e9fa1eaView commit details -
PR-URL: #510 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: NickNaso <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ac6000d - Browse repository at this point
Copy the full SHA ac6000dView commit details
Commits on Jul 18, 2019
-
doc: add ThreadSafeFunction to main README (#513)
PR-URL: #513 Reviewed-By: Gabriel Schulhof <[email protected]> Reviewed-By: NickNaso <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for d9d991b - Browse repository at this point
Copy the full SHA d9d991bView commit details
Commits on Jul 22, 2019
-
AsyncWorker: add GetResult() method
Adds an overridable `GetResult()` method, providing arguments to the callback invoked in `OnOK()`. Refs: #231 (comment) PR-URL: #512 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: NickNaso <[email protected]> Reviewed-By: Gabriel Schulhof <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 717c9ab - Browse repository at this point
Copy the full SHA 717c9abView commit details
Commits on Jul 23, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 0a1380c - Browse repository at this point
Copy the full SHA 0a1380cView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 1.6.3...1.7.0