Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v21.2.0 release proposal #50681

Merged
merged 144 commits into from
Nov 14, 2023
Merged
Changes from 1 commit
Commits
Show all changes
144 commits
Select commit Hold shift click to select a range
f6c4965
test_runner: add Date to the supported mock APIs
khaosdoctor Oct 23, 2023
766bd9c
stream: avoid getter for defaultEncoding
ronag Oct 23, 2023
905ca00
perf_hooks: reduce overhead of createHistogram
H4ad Oct 6, 2023
ad31641
test: avoid v8 deadcode on performance function
H4ad Oct 18, 2023
e008336
meta: mention other notable changes section
RafaelGSS Oct 23, 2023
bd46348
tools: update lint-md-dependencies
nodejs-github-bot Oct 23, 2023
541bdf1
src: add commit hash shorthand in zlib version
MrJithil Oct 23, 2023
3e7226a
fs: do not throw error on cpSync internals
anonrig Oct 23, 2023
31cd05c
test: ensure never settling promises are detected
aduh95 Oct 23, 2023
800206b
benchmark: move permission-fs-read to permission-processhas-fs-read
aki0501 Oct 23, 2023
d6f49c7
deps: update googletest to 116b7e5
nodejs-github-bot Oct 24, 2023
5ccdda4
tools: update eslint to 8.52.0
nodejs-github-bot Oct 24, 2023
2006b57
benchmark: skip test-benchmark-os on IBMi
mhdawson Oct 19, 2023
c4b6e1e
benchmark: add more cases to Readable.from
rluvaton Oct 24, 2023
f56ae67
stream: refactor writable _write
ronag Oct 24, 2023
62515e1
deps: update llhttp to 9.1.3
nodejs-github-bot Oct 8, 2023
f1d79b3
src: use find instead of char-by-char in FromFilePath()
lemire Oct 24, 2023
54ebfc1
build: fix building when there is only python3
zcbenz Oct 25, 2023
e2c3b01
test_runner: test return value of mocked promisified timers
mika-fischer Oct 25, 2023
e433fa5
stream: optimize creation
ronag Oct 25, 2023
d9f92bc
doc: fix TOC in `releases.md`
bryce-seefieldt Oct 25, 2023
c9b92bb
test_runner: adds built in lcov reporter
philnash Oct 25, 2023
65850a6
stream: use Array for Readable buffer
ronag Oct 25, 2023
f236657
doc: add Ethan-Arrowood as a collaborator
Oct 25, 2023
5b453d4
src: implement structuredClone in native
joyeecheung Oct 25, 2023
3f37ed9
benchmark: add benchmarks for encodings
Uzlopak Oct 25, 2023
f210915
tools: run coverage CI only on relevant files
aduh95 Oct 25, 2023
586ec48
stream: readable use bitmap accessors
ronag Oct 25, 2023
d62e812
doc: add information about Node-API versions >=9
mhdawson Oct 12, 2023
ab9cad8
test: v8: Add test-linux-perf-logger test suite
lukealbao Oct 25, 2023
4345ee2
fs,url: move `FileURLToPath` to node_url
anonrig Oct 9, 2023
b4db32e
fs,url: refactor `FileURLToPath` method
anonrig Oct 9, 2023
67cbe1b
fs,url: move `FromNamespacedPath` to `node_url`
anonrig Oct 9, 2023
7e15111
fs: add stacktrace to fs/promises
sapphi-red Oct 26, 2023
893024c
stream: avoid calls to listenerCount
ronag Oct 26, 2023
aa86c78
test: fix vm assertion actual and expected order
legendecas Oct 26, 2023
e20b272
stream: improve from perf
rluvaton Oct 26, 2023
913e4b9
test_runner: output errors of suites
MoLow Oct 26, 2023
0b11bf1
doc: update notable changes in v21.1.0
joyeecheung Oct 26, 2023
90c9dd3
tools: update doc dependencies
nodejs-github-bot Oct 26, 2023
92d6403
Revert "tools: update doc dependencies"
richardlau Oct 26, 2023
43074ee
doc: fix typo in `webstreams.md`
andrefs Oct 27, 2023
7c35055
permission: address coverity warning
mhdawson Oct 17, 2023
bd5b61f
test: fix crypto-dh error message for OpenSSL 3.x
krk Oct 27, 2023
4eb74a2
src: readiterable entries may be empty
KhafraDev Oct 27, 2023
3615a61
lib: align console.table row to the left
MrJithil Oct 28, 2023
03c4ff7
stream: use bit fields for construct/destroy
ronag Oct 28, 2023
d94010b
meta: add web-standards as web api visibility owner
legendecas Oct 28, 2023
a64217c
deps: upgrade openssl sources to quictls/openssl-3.0.12 quic1
nodejs-github-bot Oct 26, 2023
a90c6d6
deps: update archs files for openssl-3.0.12 quic1
nodejs-github-bot Oct 26, 2023
2c0d88e
stream: remove no longer relevant comment
ronag Oct 29, 2023
0116ae7
stream: pre-allocate _events
ronag Oct 29, 2023
f759048
tools: avoid npm install in deps installation
marco-ippolito Oct 30, 2023
aed5900
tools: remove unused `version` function
UlisesGascon Oct 30, 2023
44f19ce
fs: update param in jsdoc for `readdir`
Oct 30, 2023
9f55dfc
src: hide node::credentials::HasOnly outside unit
tniessen Oct 30, 2023
921e36e
doc: remove duplicate word
Flarna Oct 30, 2023
667d245
module: add application/json in accept header when fetching json module
marco-ippolito Oct 30, 2023
6dabe7c
lib: avoid memory allocation on nodeprecation flag
H4ad Oct 30, 2023
ec7005a
tools: update lint-md-dependencies to [email protected] [email protected]
nodejs-github-bot Oct 31, 2023
0a793a2
deps: update undici to 5.27.0
nodejs-github-bot Oct 31, 2023
28453ff
deps: update acorn to 8.11.2
nodejs-github-bot Oct 31, 2023
9fc29c9
tools: skip ruff on tools/gyp
targos Oct 25, 2023
52e7b6d
tools: update gyp-next to v0.16.1
targos Oct 25, 2023
1e6922e
deps: patch V8 to 11.8.172.17
targos Oct 31, 2023
c9e6e4e
meta: add [email protected] to mailmap
Oct 31, 2023
eac9cc5
esm: add import.meta.dirname and import.meta.filename
jsumners Oct 31, 2023
360f5d9
stream: fix Writable.destroy performance regression
ronag Oct 26, 2023
2f86d50
wasi: document security sandboxing status
guybedford Oct 25, 2023
773cfa5
vm: allow dynamic import with a referrer realm
legendecas Nov 1, 2023
3606a0a
module: execute `--import` sequentially
aduh95 Nov 1, 2023
57bfe53
deps: update zlib to 1.2.13.1-motley-dfc48fc
nodejs-github-bot Nov 1, 2023
02dec64
tools: improve macOS notarization process output readability
UlisesGascon Nov 1, 2023
98cfa3a
doc: recommend supported Python versions
lpinca Nov 1, 2023
6e20e08
src: print more information in C assertions
joyeecheung Nov 1, 2023
886fc48
doc: underline links
Trott Nov 1, 2023
189e5e5
deps: update nghttp2 to 1.58.0
nodejs-github-bot Nov 2, 2023
2b6d283
test: fix timeout of test-cpu-prof-dir-worker.js in LoongArch devices
shipujin Nov 2, 2023
d24de12
test: replace forEach with for...of in test-fs-realpath-buffer-encoding
niyashiyas Sep 23, 2023
f70a2dd
test: fix testsuite against zlib version 1.3
DimStar77 Nov 2, 2023
c9bd0c5
lib: use primordials for navigator.userAgent
Uzlopak Nov 2, 2023
f40435d
test: replace forEach() with for...of in test-trace-events-http
chandrakhishma Sep 22, 2023
90833a8
test: replace forEach() with for...of
Ram1607 Sep 22, 2023
f932f4c
lib: add navigator.platform
Uzlopak Nov 2, 2023
c0206bf
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Nov 3, 2023
93e3cc3
deps: upgrade npm to 10.2.3
npm-cli-bot Nov 3, 2023
7e3eb02
test: report error wpt test results
legendecas Oct 27, 2023
ee75110
test: recognize wpt completion error
legendecas Oct 28, 2023
8487cac
test: improve `UV_THREADPOOL_SIZE` tests on `.env`
anonrig Nov 3, 2023
de46a34
test: skip test-diagnostics-channel-memory-leak.js
joyeecheung Nov 3, 2023
8403030
meta: bump actions/checkout from 4.1.0 to 4.1.1
dependabot[bot] Nov 4, 2023
ff9b3bd
meta: bump actions/setup-node from 3.8.1 to 4.0.0
dependabot[bot] Nov 4, 2023
03c730b
lib: add navigator.language & navigator.languages
Uzlopak Nov 4, 2023
aa8feea
tools: improve update acorn-walk script
marco-ippolito Nov 5, 2023
b740324
src: use v8::Isolate::TryGetCurrent() in DumpJavaScriptBacktrace()
joyeecheung Nov 2, 2023
257e220
tools: compare ICU checksums before file changes
targos Nov 6, 2023
642c057
build: support Python 3.12
shipujin Nov 6, 2023
78b3432
deps: V8: cherry-pick 13192d6e10fa
kxxt Nov 6, 2023
1668798
doc: update to align `console.table` row to the left
Nov 6, 2023
f5e1c95
tools: update lint-md-dependencies to [email protected]
nodejs-github-bot Nov 7, 2023
253e206
tools: update eslint to 8.53.0
nodejs-github-bot Nov 7, 2023
479c1ea
doc: correct attribution in v20.6.0 changelog
JakobJingleheimer Nov 7, 2023
f70a59f
deps: update corepack to 0.23.0
nodejs-github-bot Nov 7, 2023
7c7be51
test: replace forEach() with for ... of loop in test-global.js
shizuka1308 Nov 7, 2023
4cbe44e
doc: update pm documentation to include resource
Ranieri93 Nov 8, 2023
6ed8fbf
test: add WPT report test duration
panva Nov 8, 2023
05e8b6e
test_runner, cli: add --test-timeout flag
shubham9411 Nov 8, 2023
ae4a7ba
test_runner: replace forEach with for of
tomhaddad Nov 8, 2023
a656bf2
doc: add missing description of argument in `subtle.encrypt`
deokjinkim Nov 8, 2023
85a527e
meta: add crypto as crypto and webcrypto docs owner
panva Nov 8, 2023
8be0efd
doc: fix typo in fs.md
3fuyang Nov 8, 2023
6dbb280
lib: add `--no-experimental-global-navigator` CLI flag
aduh95 Nov 8, 2023
931e1e7
test: relax version check with shared OpenSSL
lpinca Nov 8, 2023
22eb025
build: fix build with Python 3.12
lpinca Nov 8, 2023
065d884
benchmark: change iterations in benchmark/es/string-concatenations.js
Septa2112 Nov 9, 2023
91f37d1
stream: add support for `deflate-raw` format to webstreams compression
pirxpilot Nov 9, 2023
09c02ed
esm: bypass CJS loader in default load under `--default-type=module`
aduh95 Nov 10, 2023
52b517f
test: replace forEach with for [...] of
dygabo Nov 10, 2023
3bedaf9
buffer: improve Buffer.equals performance
kylo5aby Nov 10, 2023
1d52a57
test: replace forEach with for of
CorrWu Nov 10, 2023
2eeda3f
test: replace forEach with for of
jabali2004 Nov 10, 2023
5fa40be
lib: make event static properties non writable and configurable
BenzeneAlcohol Nov 10, 2023
b71c8c4
tls: use `validateFunction` for `options.SNICallback`
deokjinkim Nov 10, 2023
2fdcf5c
test: remove unused file
jsumners Nov 10, 2023
864cd32
test: replace forEach with for of
john-mcinall Nov 10, 2023
12e54e3
meta: bump actions/setup-python from 4.7.0 to 4.7.1
dependabot[bot] Nov 10, 2023
01bed64
test_runner: pass abortSignal to test files
MoLow Nov 10, 2023
5073a3e
deps: update base64 to 0.5.1
nodejs-github-bot Nov 8, 2023
b9f3613
build: add GN build files
zcbenz Nov 11, 2023
e25c65e
doc: add MrJithil to collaborators
MrJithil Nov 11, 2023
bc92be4
test: replace forEach() with for ... of in test-http2-single-headers.js
spiritualized Nov 11, 2023
363bc46
lib: fix assert shows diff messages in ESM and CJS
MrJithil Nov 11, 2023
49cce76
meta: fix spacing in collaborator list
aduh95 Nov 11, 2023
e978fd4
test: replace forEach() with for ... of in test-readline-keys.js
WillLiang918 Nov 11, 2023
b701567
test: replace forEach() with for .. of
bliakher Nov 11, 2023
ed293fc
lib: remove deprecated string methods
MrJithil Nov 11, 2023
4bf9cff
meta: bump ossf/scorecard-action from 2.2.0 to 2.3.1
dependabot[bot] Nov 11, 2023
4e83036
meta: bump step-security/harden-runner from 2.5.1 to 2.6.0
dependabot[bot] Nov 11, 2023
dedfb5a
meta: bump github/codeql-action from 2.21.9 to 2.22.5
dependabot[bot] Nov 11, 2023
14e3675
errors: improve hideStackFrames
Uzlopak Nov 11, 2023
8be718a
test: use destructuring for accessing setting values
yedlosh Nov 11, 2023
5fcd67a
tools: add macOS notarization stapler
UlisesGascon Nov 11, 2023
9e7131f
meta: add web-standards as WPTs owner
panva Nov 11, 2023
13b266f
2023-11-14, Version 21.2.0 (Current)
targos Nov 12, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: replace forEach() with for .. of
PR-URL: #50605
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
  • Loading branch information
bliakher authored and targos committed Nov 14, 2023
commit b701567a46c2988a368d715d52d80fe605d7d4fd
13 changes: 7 additions & 6 deletions test/parallel/test-async-wrap-constructor.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 6,16 @@ require('../common');
const assert = require('assert');
const async_hooks = require('async_hooks');

[0, 1, false, true, null, 'hello'].forEach((badArg) => {
const falsyValues = [0, 1, false, true, null, 'hello'];
for (const badArg of falsyValues) {
const hookNames = ['init', 'before', 'after', 'destroy', 'promiseResolve'];
hookNames.forEach((field) => {
for (const hookName of hookNames) {
assert.throws(() => {
async_hooks.createHook({ [field]: badArg });
async_hooks.createHook({ [hookName]: badArg });
}, {
code: 'ERR_ASYNC_CALLBACK',
name: 'TypeError',
message: `hook.${field} must be a function`
message: `hook.${hookName} must be a function`
});
});
});
}
}