tools: update doc to [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] #49988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
lpinca
force-pushed
the
actions/tools-update-doc
branch
from
bcca2e8
to
af4b2d9
Compare
MoLow
approved these changes
Oct 1, 2023
lpinca
approved these changes
Oct 1, 2023
|
I'm not sure why the coverage job fails. Can we ignore it? |
lpinca
force-pushed
the
actions/tools-update-doc
branch
from
af4b2d9
to
7710af5
Compare
nodejs-github-bot
changed the title
aduh95
force-pushed
the
actions/tools-update-doc
branch
from
6d492c8
to
269c8b8
Compare
aduh95
added
author ready
aduh95
force-pushed
the
actions/tools-update-doc
branch
from
269c8b8
to
bcad579
Compare
aduh95
approved these changes
Oct 26, 2023
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6431c65 |
|
I think this has broken the without-intl build: 17:31:46 npm WARN cli npm v10.2.0 does not support Node.js v22.0.0-pre. This version of npm supports the following node versions: `^18.17.0 || >=20.5.0`. You can find the latest version at https://nodejs.org/.
17:31:47
17:31:47 added 109 packages, and audited 110 packages in 1s
17:31:47
17:31:47 94 packages are looking for funding
17:31:47 run `npm fund` for details
17:31:47
17:31:47 found 0 vulnerabilities
17:31:47 file:///home/iojs/build/workspace/node-test-commit-linux-containered/tools/doc/node_modules/micromark-util-character/index.js:5
17:31:47 const unicodePunctuationInternal = regexCheck(/\p{P}/u)
17:31:47 ^^^^^^^^
17:31:47
17:31:47 SyntaxError: Invalid regular expression: /\p{P}/u: Invalid property name
17:31:47 at ModuleLoader.moduleStrategy (node:internal/modules/esm/translators:155:18)
17:31:47 at callTranslator (node:internal/modules/esm/loader:285:14)
17:31:47 at ModuleLoader.moduleProvider (node:internal/modules/esm/loader:291:30)
17:31:47
17:31:47 Node.js v22.0.0-pre
17:31:47 /bin/sh: 5: node: not found
17:31:47 Makefile:374: recipe for target 'test/addons/.docbuildstamp' failedOpened a revert: #50414 |
5 tasks
This was referenced Oct 26, 2023
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] PR-URL: nodejs#49988 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
targos
pushed a commit
that referenced
this pull request
Nov 11, 2023
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] PR-URL: #49988 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
UlisesGascon
pushed a commit
that referenced
this pull request
Dec 11, 2023
- [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] PR-URL: #49988 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of doc to [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected].