esm: import.meta.resolve exact module not found errors should return #49038

guybedford · 2023-08-06T03:08:19Z

This resolves #49010, ensuring that not found errors to exact modules in import.meta.resolve still return the resolved string. Package not found errors remain module not found errors.

@nodejs/modules

nodejs-github-bot · 2023-08-06T03:08:24Z

Review requested:

@nodejs/loaders
@nodejs/modules

guybedford · 2023-08-06T17:43:53Z

@JakobJingleheimer wondering if you have any clues as to what might be up with this asan test failure here?

JakobJingleheimer · 2023-08-06T18:33:32Z

Looking at the output, it seems all cases are reporting okay, which makes me think there's an async issue (something is not waiting as it should). No idea why this would be isolated to ASan.

The test output appears to stop on:

Loader hooks → should handle a throwing top-level body → should handle empty plain object

~~Perhaps error here is not defined (or worse, null):~~

node/lib/internal/modules/esm/initialize_import_meta.js

Line 22 in adee9bd

({ url } = error);

Ah, no, we know it's not because of switch (error?.code).

I would guess something is unexpectedly throwing, and that's getting swallowed (and ESM worker would be the most likely suspect for swallowing it as we experienced that A LOT during the off-thread PR).

I would still look here for the source of the unexpected throw

node/lib/internal/modules/esm/initialize_import_meta.js

Lines 22 to 25 in adee9bd

    
           ({ url } = error); 
        
           if (url) { 
        
             return url; 
        
           }

(and use that fs.writeSync trick to ensure debugging output actually happens).

GeoffreyBooth · 2023-08-06T20:08:29Z

Looking at the output, it seems all cases are reporting okay, which makes me think there’s an async issue (something is not waiting as it should). No idea why this would be isolated to ASan.

https://openjs-foundation.slack.com/archives/C053UCCP940/p1690842970936839:

is there a reason the ASan build failed in ^? it did error in one of the ESM loader tests… so maybe it’s related… but the output doesn’t seem to show why 🤔 maybe there’s some non-determinism involved?

From July 31, so this might’ve been introduced by one of the earlier recent loaders PRs. cc @izaakschroeder

lib/internal/errors.js

lib/internal/modules/esm/resolve.js

nodejs-github-bot · 2023-08-10T15:34:48Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53132/

nodejs-github-bot · 2023-08-11T07:50:07Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53178/

nodejs-github-bot · 2023-08-11T08:57:47Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53182/

nodejs-github-bot · 2023-08-11T13:46:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53192/

nodejs-github-bot · 2023-08-11T16:01:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53204/

nodejs-github-bot · 2023-08-11T23:39:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53211/

nodejs-github-bot · 2023-08-12T05:01:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53219/

nodejs-github-bot · 2023-08-12T22:22:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/53255/

nodejs-github-bot · 2023-08-13T00:02:05Z

Landed in 569267d

PR-URL: nodejs#49038 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

PR-URL: #49038 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

PR-URL: nodejs#49038 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

PR-URL: #49038 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

PR-URL: nodejs#49038 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

PR-URL: #49038 Backport-PR-URL: #50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

PR-URL: nodejs/node#49038 Backport-PR-URL: nodejs/node#50669 Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Jan Krems <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

esm: import.meta.resolve exact module not found errors should return

adee9bd

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Aug 6, 2023

This was referenced Aug 6, 2023

esm: unflag import.meta.resolve #49028

Merged

import.meta.resolve non existing paths. #49010

Closed

GeoffreyBooth approved these changes Aug 6, 2023

View reviewed changes

jkrems approved these changes Aug 6, 2023

View reviewed changes

aduh95 reviewed Aug 7, 2023

View reviewed changes

lib/internal/errors.js Outdated Show resolved Hide resolved

explicit url arg

e2f007b

GeoffreyBooth approved these changes Aug 7, 2023

View reviewed changes

aduh95 reviewed Aug 7, 2023

View reviewed changes

lib/internal/errors.js Outdated Show resolved Hide resolved

aduh95 reviewed Aug 7, 2023

View reviewed changes

lib/internal/modules/esm/resolve.js Show resolved Hide resolved

pr feedback

ebcde3d

aduh95 approved these changes Aug 7, 2023

View reviewed changes

jimmywarting mentioned this pull request Aug 8, 2023

esm: add import.meta.dirname and import.meta.filename #48740

Merged

VoltrexKeyva approved these changes Aug 9, 2023

View reviewed changes

JakobJingleheimer approved these changes Aug 9, 2023

View reviewed changes

github-actions bot mentioned this pull request Aug 11, 2023

CI Reliability 2023-08-11 nodejs/reliability#634

Open

29 tasks

This comment was marked as duplicate.

Sign in to view

debadree25 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 12, 2023

GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed needs-ci PRs that need a full CI run. labels Aug 12, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 13, 2023

nodejs-github-bot merged commit 569267d into nodejs:main Aug 13, 2023
30 checks passed

This was referenced Aug 13, 2023

CI Reliability 2023-08-13 nodejs/reliability#635

Open

CI Reliability 2023-08-14 nodejs/reliability#636

Open

UlisesGascon mentioned this pull request Aug 15, 2023

v20.6.0 proposal #49185

Merged

targos mentioned this pull request Nov 11, 2023

[v18.x] Backport most ESM and customization hook changes #50669

Closed

targos added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Nov 23, 2023

targos mentioned this pull request Nov 28, 2023

v18.19.0 release proposal #50953

Merged

hi-ogawa mentioned this pull request Jan 27, 2024

fix(vm): improve error when module is not found vitest-dev/vitest#5053

Merged

6 tasks

jdalton mentioned this pull request Feb 16, 2024

import.meta.resolve(Sync) should not throw error when module file cannot be found oven-sh/bun#8928

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

esm: import.meta.resolve exact module not found errors should return #49038

esm: import.meta.resolve exact module not found errors should return #49038

guybedford commented Aug 6, 2023

nodejs-github-bot commented Aug 6, 2023

guybedford commented Aug 6, 2023

JakobJingleheimer commented Aug 6, 2023 •

edited

Loading

GeoffreyBooth commented Aug 6, 2023

nodejs-github-bot commented Aug 10, 2023

nodejs-github-bot commented Aug 11, 2023

nodejs-github-bot commented Aug 11, 2023

nodejs-github-bot commented Aug 11, 2023

nodejs-github-bot commented Aug 11, 2023

nodejs-github-bot commented Aug 11, 2023

This comment was marked as duplicate.

This comment was marked as duplicate.

nodejs-github-bot commented Aug 12, 2023

nodejs-github-bot commented Aug 12, 2023

nodejs-github-bot commented Aug 13, 2023

esm: import.meta.resolve exact module not found errors should return #49038

esm: import.meta.resolve exact module not found errors should return #49038

Conversation

guybedford commented Aug 6, 2023

nodejs-github-bot commented Aug 6, 2023

guybedford commented Aug 6, 2023

JakobJingleheimer commented Aug 6, 2023 • edited Loading

GeoffreyBooth commented Aug 6, 2023

nodejs-github-bot commented Aug 10, 2023

nodejs-github-bot commented Aug 11, 2023

nodejs-github-bot commented Aug 11, 2023

nodejs-github-bot commented Aug 11, 2023

nodejs-github-bot commented Aug 11, 2023

nodejs-github-bot commented Aug 11, 2023

This comment was marked as duplicate.

This comment was marked as duplicate.

nodejs-github-bot commented Aug 12, 2023

nodejs-github-bot commented Aug 12, 2023

nodejs-github-bot commented Aug 13, 2023

JakobJingleheimer commented Aug 6, 2023 •

edited

Loading