Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve inspector.close() description #48494

Merged
merged 1 commit into from
Jun 21, 2023
Merged

doc: improve inspector.close() description #48494

merged 1 commit into from
Jun 21, 2023

Conversation

mmarchini
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol labels Jun 19, 2023
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 19, 2023
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 21, 2023
@nodejs-github-bot nodejs-github-bot merged commit 49951ec into nodejs:main Jun 21, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 49951ec

RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@mmarchini @RafaelGSS
doc: improve inspector.close() description
37bc0ea 
PR-URL: #48494
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@mmarchini @Ceres6
doc: improve inspector.close() description
2ac812e 
PR-URL: nodejs#48494
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@mmarchini @Ceres6
doc: improve inspector.close() description
47a4935 
PR-URL: nodejs#48494
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
@ruyadorno
Copy link
Member

This commit does not land cleanly on and will need manual backport in case we want it in v18.

@ruyadorno ruyadorno added the backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@aymen94 aymen94 aymen94 approved these changes

@aduh95 aduh95 aduh95 approved these changes

@Flarna Flarna Flarna approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. doc Issues and PRs related to the documentations. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mmarchini @nodejs-github-bot @ruyadorno @jasnell @lpinca @aymen94 @aduh95 @Flarna