-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib: create weakRef only if any signals provided #48448
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
atlowChemi:lib--create-weakRef-only-if-any-signals-provided
Jun 15, 2023
Merged
lib: create weakRef only if any signals provided #48448
nodejs-github-bot
merged 1 commit into
nodejs:main
from
atlowChemi:lib--create-weakRef-only-if-any-signals-provided
Jun 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linkgoron
reviewed
Jun 13, 2023
b74da91
to
f70772d
Compare
aduh95
reviewed
Jun 13, 2023
Linkgoron
reviewed
Jun 13, 2023
f70772d
to
26d8fbe
Compare
Linkgoron
reviewed
Jun 13, 2023
26d8fbe
to
6cb4ad9
Compare
aduh95
approved these changes
Jun 13, 2023
Linkgoron
approved these changes
Jun 13, 2023
MoLow
approved these changes
Jun 13, 2023
20 tasks
lpinca
approved these changes
Jun 14, 2023
22 tasks
Landed in f3ee4e2 |
29 tasks
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
PR-URL: #48448 Fixes: #48419 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
atlowChemi
added a commit
to atlowChemi/node
that referenced
this pull request
Jul 17, 2023
PR-URL: nodejs#48448 Fixes: nodejs#48419 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
danielleadams
pushed a commit
that referenced
this pull request
Jul 17, 2023
PR-URL: #48448 Backport-PR-URL: #48800 Fixes: #48419 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48448 Fixes: nodejs#48419 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48448 Fixes: nodejs#48419 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Nitzan Uziely <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
backported-to-v18.x
PRs backported to the v18.x-staging branch.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #48419