-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: fix typo in events.md #48436
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
RaisinTen:doc-fix-typo-in-events.md
Jun 12, 2023
Merged
doc: fix typo in events.md #48436
nodejs-github-bot
merged 1 commit into
nodejs:main
from
RaisinTen:doc-fix-typo-in-events.md
Jun 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Darshan Sen <[email protected]>
Fast-track has been requested by @RaisinTen. Please 👍 to approve. |
cjihrig
approved these changes
Jun 12, 2023
MoLow
approved these changes
Jun 12, 2023
lpinca
approved these changes
Jun 12, 2023
Landed in 4e0066e |
Commit Queue failed- Loading data for nodejs/node/pull/48436 ✔ Done loading data for nodejs/node/pull/48436 ----------------------------------- PR info ------------------------------------ Title doc: fix typo in events.md (#48436) Author Darshan Sen (@RaisinTen) Branch RaisinTen:doc-fix-typo-in-events.md -> nodejs:main Labels doc, events, fast-track, author ready Commits 1 - doc: fix typo in events.md Committers 1 - Darshan Sen PR-URL: https://github.com/nodejs/node/pull/48436 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48436 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 12 Jun 2023 13:23:41 GMT ✔ Approvals: 3 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/48436#pullrequestreview-1474924898 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48436#pullrequestreview-1475008547 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48436#pullrequestreview-1475298533 ℹ This PR is being fast-tracked ⚠ This PR was merged on Mon, 12 Jun 2023 16:15:04 GMT ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5246072814 |
Commit Queue failed- Loading data for nodejs/node/pull/48436 ✔ Done loading data for nodejs/node/pull/48436 ----------------------------------- PR info ------------------------------------ Title doc: fix typo in events.md (#48436) Author Darshan Sen (@RaisinTen) Branch RaisinTen:doc-fix-typo-in-events.md -> nodejs:main Labels doc, events, fast-track, author ready, commit-queue-failed Commits 1 - doc: fix typo in events.md Committers 1 - Darshan Sen PR-URL: https://github.com/nodejs/node/pull/48436 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48436 Reviewed-By: Colin Ihrig Reviewed-By: Moshe Atlow Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 12 Jun 2023 13:23:41 GMT ✔ Approvals: 3 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/48436#pullrequestreview-1474924898 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/48436#pullrequestreview-1475008547 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48436#pullrequestreview-1475298533 ℹ This PR is being fast-tracked ⚠ This PR was merged on Mon, 12 Jun 2023 16:15:04 GMT ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5246167439 |
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #48436 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs#48436 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
Signed-off-by: Darshan Sen <[email protected]> PR-URL: nodejs#48436 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
ruyadorno
pushed a commit
that referenced
this pull request
Sep 7, 2023
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #48436 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Merged
ruyadorno
pushed a commit
that referenced
this pull request
Sep 13, 2023
Signed-off-by: Darshan Sen <[email protected]> PR-URL: #48436 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-failed
An error occurred while landing this pull request using GitHub Actions.
doc
Issues and PRs related to the documentations.
events
Issues and PRs related to the events subsystem / EventEmitter.
fast-track
PRs that do not need to wait for 48 hours to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.