Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update ada to 2.5.1 #48319

Closed
wants to merge 3 commits into from
Closed

deps: update ada to 2.5.1 #48319

wants to merge 3 commits into from

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Jun 3, 2023 •
edited
Loading

This is an automated update of ada to 2.5.1.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Jun 3, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/url

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 3, 2023
@anonrig anonrig added the commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. label Jun 3, 2023
@anonrig anonrig requested a review from lpinca June 3, 2023 16:52
@anonrig
Copy link
Member

anonrig commented Jun 3, 2023

I added changes to this pull request, since these changes are required for the web platform tests to update.

This PR fixes: #48157

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Jun 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 3, 2023

Fast-track has been requested by @anonrig. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 3, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52071/

@anonrig
Copy link
Member

anonrig commented Jun 3, 2023

PS: This pull request includes a bug fix (for URLs that contain 0 port number), as well as a fix for the spec compliance on URL getter.

@aduh95
Copy link
Contributor

aduh95 commented Jun 3, 2023

node/doc/contributing/collaborator-guide.md

Lines 543 to 544 in 260092e

All commits should be self-contained, meaning every commit should pass all
tests. This makes it much easier when bisecting to find a breaking change.

I guess we would need to squash 019723c and c3a1c64 upon landing, right? Or maybe land c3a1c64 first and update the status when upgrading ada.

@anonrig
Copy link
Member

anonrig commented Jun 3, 2023

@aduh95 We don't need to squash since all commits build correctly. In the second commit, I added url origin getter to url.json wpt file, and in 3rd I removed it. But even with wpt files update commit, everything works correctly.

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52076/

@github-actions github-actions bot mentioned this pull request Jun 4, 2023
Open
30 tasks
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52078/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52089/

@github-actions github-actions bot mentioned this pull request Jun 5, 2023
Open
30 tasks
@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2023
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52102/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52116/

@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/52118/

@github-actions github-actions bot mentioned this pull request Jun 6, 2023
Open
20 tasks
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2023
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 23c7f65...f2670a6

nodejs-github-bot added a commit that referenced this pull request Jun 7, 2023
@nodejs-github-bot
deps: update ada to 2.5.1
11bd9f9 
PR-URL: #48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jun 7, 2023
@anonrig @nodejs-github-bot
test: update url web-platform tests
e6e0110 
PR-URL: #48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jun 7, 2023
@anonrig @nodejs-github-bot
url: conform to origin getter spec changes
f2670a6 
PR-URL: #48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@targos targos deleted the actions/tools-update-ada branch June 7, 2023 11:47
This was referenced Jun 9, 2023
Open
Open
@hemanth hemanth mentioned this pull request Jun 11, 2023
Closed
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@nodejs-github-bot @RafaelGSS
deps: update ada to 2.5.1
8cd56c1 
PR-URL: #48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@anonrig @RafaelGSS
test: update url web-platform tests
764119b 
PR-URL: #48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Jul 3, 2023
@anonrig @RafaelGSS
url: conform to origin getter spec changes
fafe651 
PR-URL: #48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jul 3, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@nodejs-github-bot @Ceres6
deps: update ada to 2.5.1
262f965 
PR-URL: nodejs#48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig @Ceres6
test: update url web-platform tests
0bdbf9d 
PR-URL: nodejs#48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig @Ceres6
url: conform to origin getter spec changes
882b9dd 
PR-URL: nodejs#48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@nodejs-github-bot @Ceres6
deps: update ada to 2.5.1
d467e03 
PR-URL: nodejs#48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig @Ceres6
test: update url web-platform tests
5ba5335 
PR-URL: nodejs#48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@anonrig @Ceres6
url: conform to origin getter spec changes
34ff09a 
PR-URL: nodejs#48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
@nodejs-github-bot @ruyadorno
deps: update ada to 2.5.1
a2964a4 
PR-URL: #48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
@anonrig @ruyadorno
test: update url web-platform tests
cb92c4b 
PR-URL: #48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
ruyadorno pushed a commit that referenced this pull request Aug 29, 2023
@anonrig @ruyadorno
url: conform to origin getter spec changes
d428e6b 
PR-URL: #48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Aug 29, 2023
Merged
ruyadorno pushed a commit that referenced this pull request Sep 1, 2023
@anonrig @ruyadorno
url: conform to origin getter spec changes
f59c963 
PR-URL: #48319
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-rebase Add this label to allow the Commit Queue to land a PR in several commits. dependencies Pull requests that update a dependency file. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nodejs-github-bot @anonrig @aduh95 @benjamingr @lpinca