-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix test-net-autoselectfamily
for kernel without IPv6 support
#48265
test: fix test-net-autoselectfamily
for kernel without IPv6 support
#48265
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
@@ -85,6 85,8 @@ function createDnsServer(ipv6Addr, ipv4Addr, cb) { | |||
if (common.hasIPv6) { | |||
assert.strictEqual(error.code, 'ECONNREFUSED'); | |||
assert.strictEqual(error.message, `connect ECONNREFUSED ::1:${port}`); | |||
} else if (error.code === 'EAFNOSUPPORT') { | |||
assert.strictEqual(error.message, `connect EAFNOSUPPORT ::1:${port} - Local (undefined:undefined)`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That undefined:undefined
is a bit weird.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, it makes sense for systems without IPv6 support to not know how to represent invalid/unknown source [address]:port
. 😄
It is possible to adjust all exceptionWithHostPort(..., additional)
calls so they will try to provide more descriptive error in this specific case, but not worth it imho.
Commit Queue failed- Loading data for nodejs/node/pull/48265 ✔ Done loading data for nodejs/node/pull/48265 ----------------------------------- PR info ------------------------------------ Title test: fix `test-net-autoselectfamily` for kernel without IPv6 support (#48265) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch LiviaMedeiros:net-test-asf-cmd-option-noipv6 -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: fix `test-net-autoselectfamily` for kernel without IPv6 support Committers 1 - LiviaMedeiros PR-URL: https://github.com/nodejs/node/pull/48265 Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48265 Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 31 May 2023 16:13:48 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48265#pullrequestreview-1456022547 ✘ This PR needs to wait 82 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-06-01T12:55:51Z: https://ci.nodejs.org/job/node-test-pull-request/52050/ - Querying data for job/node-test-pull-request/52050/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5167492972 |
Landed in 9c5efdd |
PR-URL: #48265 Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#48265 Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: nodejs#48265 Reviewed-By: Luigi Pinca <[email protected]>
hi @LiviaMedeiros this commit is not landing cleanly in |
Sure; I'll open backport PR if https://github.com/nodejs/node/blame/v18.18.0-proposal/test/parallel/test-net-autoselectfamily-commandline-option.js will become affected by this problem and this PR still won't be landable. Right now affected test seem to not rely in |
If
CONFIG_IPV6
is disabled, the observed error on some platforms isEAFNOSUPPORT
instead ofEADDRNOTAVAIL
.