test: fix test-net-autoselectfamily for kernel without IPv6 support
#48265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
approved these changes
Jun 1, 2023
lpinca
reviewed
Jun 1, 2023
| @@ -85,6 85,8 @@ function createDnsServer(ipv6Addr, ipv4Addr, cb) { | |||
| if (common.hasIPv6) { | |||
| assert.strictEqual(error.code, 'ECONNREFUSED'); | |||
| assert.strictEqual(error.message, `connect ECONNREFUSED ::1:${port}`); | |||
| } else if (error.code === 'EAFNOSUPPORT') { | |||
| assert.strictEqual(error.message, `connect EAFNOSUPPORT ::1:${port} - Local (undefined:undefined)`); | |||
There was a problem hiding this comment.
That undefined:undefined is a bit weird.
There was a problem hiding this comment.
Well, it makes sense for systems without IPv6 support to not know how to represent invalid/unknown source [address]:port. 😄
It is possible to adjust all exceptionWithHostPort(..., additional) calls so they will try to provide more descriptive error in this specific case, but not worth it imho.
lpinca
approved these changes
Jun 1, 2023
This was referenced Jun 2, 2023
lpinca
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/48265 ✔ Done loading data for nodejs/node/pull/48265 ----------------------------------- PR info ------------------------------------ Title test: fix `test-net-autoselectfamily` for kernel without IPv6 support (#48265) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch LiviaMedeiros:net-test-asf-cmd-option-noipv6 -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: fix `test-net-autoselectfamily` for kernel without IPv6 support Committers 1 - LiviaMedeiros PR-URL: https://github.com/nodejs/node/pull/48265 Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/48265 Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 31 May 2023 16:13:48 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/48265#pullrequestreview-1456022547 ✘ This PR needs to wait 82 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2023-06-01T12:55:51Z: https://ci.nodejs.org/job/node-test-pull-request/52050/ - Querying data for job/node-test-pull-request/52050/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/5167492972 |
This was referenced Jun 5, 2023
LiviaMedeiros
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 9c5efdd |
RafaelGSS
pushed a commit
that referenced
this pull request
Jul 3, 2023
PR-URL: #48265 Reviewed-By: Luigi Pinca <[email protected]>
Merged
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48265 Reviewed-By: Luigi Pinca <[email protected]>
Ceres6
pushed a commit
to Ceres6/node
that referenced
this pull request
Aug 14, 2023
PR-URL: nodejs#48265 Reviewed-By: Luigi Pinca <[email protected]>
|
hi @LiviaMedeiros this commit is not landing cleanly in |
ruyadorno
added
the
backport-requested-v18.x
|
Sure; I'll open backport PR if https://github.com/nodejs/node/blame/v18.18.0-proposal/test/parallel/test-net-autoselectfamily-commandline-option.js will become affected by this problem and this PR still won't be landable. Right now affected test seem to not rely in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
CONFIG_IPV6is disabled, the observed error on some platforms isEAFNOSUPPORTinstead ofEADDRNOTAVAIL.