Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: include v19.1.0 #45462

Merged
merged 1 commit into from
Nov 15, 2022
Merged

doc: include v19.1.0 #45462

merged 1 commit into from
Nov 15, 2022

Conversation

RafaelGSS
Copy link
Member

@RafaelGSS RafaelGSS commented Nov 14, 2022 •
edited
Loading

It was missed in the last release

cc: @nodejs/releasers

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Nov 14, 2022
@richardlau richardlau added the fast-track PRs that do not need to wait for 48 hours to land. label Nov 14, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @richardlau. Please 👍 to approve.

@RafaelGSS
Copy link
Member Author

@richardlau probably the lint error should be ignored, right?

@aduh95
Copy link
Contributor

aduh95 commented Nov 14, 2022

@richardlau probably the lint error should be ignored, right?

It should be fixed, really. Working on a PR.

@aduh95 aduh95 mentioned this pull request Nov 14, 2022
Merged
@RafaelGSS
Copy link
Member Author

@aduh95 Does it need to wait #45463 to land?

@RafaelGSS RafaelGSS mentioned this pull request Nov 14, 2022
Merged
@RafaelGSS @aduh95
doc: include v19.1.0 in CHANGELOG.md
08c2d43 
It was missed in the last release.

Refs: nodejs@3770d3a
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 15, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 15, 2022
@nodejs-github-bot nodejs-github-bot merged commit 0a592e4 into nodejs:main Nov 15, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 0a592e4

ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
@RafaelGSS @ruyadorno
doc: include v19.1.0 in CHANGELOG.md
4128c27 
It was missed in the last release.

Refs: 3770d3a
PR-URL: #45462
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Harshitha K P <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
Merged
@danielleadams danielleadams added dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarshithaKP HarshithaKP HarshithaKP approved these changes

@aduh95 aduh95 aduh95 approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@richardlau richardlau richardlau approved these changes

@anonrig anonrig anonrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.