Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: improve internal/worker/io.js coverage #42387

Merged
merged 1 commit into from
Jul 31, 2023
Merged

test: improve internal/worker/io.js coverage #42387

merged 1 commit into from
Jul 31, 2023

Conversation

kuriyosh
Copy link
Contributor

This improves a test coverage in internal/worker/io.js

ref: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485

This PR adds a test that validates the BroadcastChannel.ref() method works correctly.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 18, 2022
@marsonya marsonya added worker Issues and PRs related to Worker support. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 2, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 2, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43267/

This was referenced Apr 3, 2022
Open
Open
Open
Open
Open
@watilde watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 8, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 8, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43386/

This was referenced Apr 9, 2022
Open
Open
Open
Open
Open
Open
@kuriyosh kuriyosh added the request-ci Add this label to start a Jenkins CI on a PR. label May 13, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 13, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/43981/

This was referenced May 14, 2022
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52904/

This was referenced Jul 24, 2023
Open
Open
Open
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52974/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52975/

This was referenced Jul 30, 2023
Open
Open
@debadree25 debadree25 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2023
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jul 31, 2023
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/42387
✔  Done loading data for nodejs/node/pull/42387
----------------------------------- PR info ------------------------------------
Title      test: improve internal/worker/io.js coverage (#42387)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     kuriyosh:test-bc-ref -> nodejs:main
Labels     test, author ready, worker, needs-ci
Commits    1
 - test: improve internal/worker/io.js coverage
Committers 1
 - Antoine du Hamel 
PR-URL: https://github.com/nodejs/node/pull/42387
Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485
Reviewed-By: Darshan Sen 
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Akhil Marsonya 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Luigi Pinca 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Michael Dawson 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/42387
Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485
Reviewed-By: Darshan Sen 
Reviewed-By: Rich Trott 
Reviewed-By: James M Snell 
Reviewed-By: Akhil Marsonya 
Reviewed-By: Daijiro Wachi 
Reviewed-By: Luigi Pinca 
Reviewed-By: Debadree Chatterjee 
Reviewed-By: Michael Dawson 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last approving review:
   ⚠  - test: improve internal/worker/io.js coverage
   ℹ  This PR was created on Fri, 18 Mar 2022 04:50:02 GMT
   ✔  Approvals: 8
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/42387#pullrequestreview-915843402
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/42387#pullrequestreview-916593214
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/42387#pullrequestreview-922217924
   ✔  - Akhil Marsonya (@marsonya): https://github.com/nodejs/node/pull/42387#pullrequestreview-929588367
   ✔  - Daijiro Wachi (@watilde): https://github.com/nodejs/node/pull/42387#pullrequestreview-935904833
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42387#pullrequestreview-1293927250
   ✔  - Debadree Chatterjee (@debadree25): https://github.com/nodejs/node/pull/42387#pullrequestreview-1405859339
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/42387#pullrequestreview-1413851278
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2023-07-29T12:49:45Z: https://ci.nodejs.org/job/node-test-pull-request/52975/
- Querying data for job/node-test-pull-request/52975/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/5713219443

@debadree25 debadree25 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jul 31, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 31, 2023
@nodejs-github-bot nodejs-github-bot merged commit 1dcfc65 into nodejs:main Jul 31, 2023
9 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1dcfc65

pluris pushed a commit to pluris/node that referenced this pull request Aug 6, 2023
@kuriyosh
test: improve internal/worker/io.js coverage
ff54c9f 
PR-URL: nodejs#42387
Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
pluris pushed a commit to pluris/node that referenced this pull request Aug 7, 2023
@kuriyosh
test: improve internal/worker/io.js coverage
94b6e11 
PR-URL: nodejs#42387
Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@kuriyosh @Ceres6
test: improve internal/worker/io.js coverage
f69c5c1 
PR-URL: nodejs#42387
Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@kuriyosh @Ceres6
test: improve internal/worker/io.js coverage
7d07fde 
PR-URL: nodejs#42387
Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
UlisesGascon pushed a commit to UlisesGascon/node that referenced this pull request Aug 14, 2023
@kuriyosh @UlisesGascon
test: improve internal/worker/io.js coverage
4c1e458 
PR-URL: nodejs#42387
Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 15, 2023
@kuriyosh @RafaelGSS
test: improve internal/worker/io.js coverage
891edc9 
PR-URL: #42387
Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@UlisesGascon UlisesGascon mentioned this pull request Aug 15, 2023
Merged
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Aug 15, 2023
@kuriyosh @RafaelGSS
test: improve internal/worker/io.js coverage
9e33a36 
PR-URL: nodejs#42387
Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Aug 17, 2023
@kuriyosh @RafaelGSS
test: improve internal/worker/io.js coverage
62e23f8 
PR-URL: #42387
Refs: https://coverage.nodejs.org/coverage-6d3920d579a3dc3a/lib/internal/worker/io.js.html#L485
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Debadree Chatterjee <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@debadree25 debadree25 debadree25 approved these changes

@marsonya marsonya marsonya approved these changes

@mhdawson mhdawson mhdawson approved these changes

@watilde watilde watilde approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.