Fix updating the Subflow name during a copy #4809
Conversation
| * | ||
| * @param {object} sf The Subflow to add. | ||
| * @param {boolean|undefined} createNewIds Whether to update the name. | ||
| */ | ||
| function addSubflow(sf, createNewIds) { |
There was a problem hiding this comment.
Is createNewIds supposed to only update the name or also the id (inside this function)?
Note: this function is exported.
There was a problem hiding this comment.
It is probably just a lazily named argument because it is createNewIds from the calling function. The ids will have already been regenerated by the time this is called - on the basis that it is a duplicate subflow we're importing a copy. As a copy, we want to update the name to make sure its unique.
There was a problem hiding this comment.
Ok thanks, maybe we can call it something else?
What does that result in? When I test with 4.0.1, if I import an existing subflow and request to import a copy, I get the copy with the updated name. It looks like it's working. Please can you provide the steps needed to reproduce the issue. We can argue over whether the copy numbering should start with 1 or 2... but that's a separate matter for this PR. |
|
If you import the subflow below for the first time you will have the name of Subflow (tab) [{"id":"fce385f33b15f673","type":"subflow","name":"Subflow 1","info":"","in":[],"out":[]},{"id":"1a65476b8e0791f5","type":"subflow:fce385f33b15f673","z":"15cdbf1d258ebb57","name":"","x":380,"y":540,"wires":[]}]And now if you re-import it, copy the subflow (tab), you will also have the name |
Co-authored-by: Nick O'Leary <[email protected]>
Proposed changes
Fix updating the Subflow name during a copy:
addSubflowcausescreateNewIdsis false.Related PR: #4757.
Checklist
npm run testto verify the unit tests pass