Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monaco-0-49-0 #4725

Merged
merged 3 commits into from
May 29, 2024
Merged

Monaco-0-49-0 #4725

merged 3 commits into from
May 29, 2024

Conversation

Steve-Mcl
Copy link
Contributor

@Steve-Mcl Steve-Mcl commented May 26, 2024

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Vendor update

Proposed changes

Updates monaco to latest V0.49.0

https://github.com/node-red/nr-monaco-build/releases/tag/0.49.0

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@FabsMuller
Copy link
Contributor

Stephen, I sent you a pvt on NR forum.

@knolleary
Copy link
Member

@Steve-Mcl does this correspond to a tagged release on https://github.com/node-red/nr-monaco-build ? I'd prefer that we are able to point to a tag on that repo when copying files over so we have a clear sense of their pedigree.

@Steve-Mcl
Copy link
Contributor Author

Steve-Mcl commented May 29, 2024

@Steve-Mcl does this correspond to a tagged release on https://github.com/node-red/nr-monaco-build ? I'd prefer that we are able to point to a tag on that repo when copying files over so we have a clear sense of their pedigree.

No, but it does directly relate to the branch https://github.com/node-red/nr-monaco-build/tree/update-for-v4 which was updated first, to generate this PR

We could merge and tag that first if need be?

@Steve-Mcl Steve-Mcl requested a review from knolleary May 29, 2024 10:14
@Steve-Mcl Steve-Mcl added this to the 4.0 milestone May 29, 2024
@knolleary
Copy link
Member

I have merged and tagged the changes in the monaco repo. This PR syncs the changes from https://github.com/node-red/nr-monaco-build/releases/tag/0.49.0 into the NR repo

@knolleary knolleary merged commit 25205f7 into dev May 29, 2024
4 checks passed
@Steve-Mcl Steve-Mcl deleted the monaco-0-49-0 branch May 29, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants