Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix three error typos in monaco.js #4660

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

JoshuaCWebDeveloper
Copy link
Contributor

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

I found three typos in the monaco.js editor file while doing a code review.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

Copy link

linux-foundation-easycla bot commented Apr 15, 2024

CLA Signed

  • ✅login: JoshuaCWebDeveloper / (c855050)

The committers listed above are authorized under a signed CLA.

@Steve-Mcl
Copy link
Contributor

Hi @JoshuaCWebDeveloper thanks for that.

Can you please sign the EasyCLA as described

- login: @JoshuaCWebDeveloper / name: Joshua Carter . The commit (c855050) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

@JoshuaCWebDeveloper
Copy link
Contributor Author

Hi @JoshuaCWebDeveloper thanks for that.

Can you please sign the EasyCLA as described

- login: @JoshuaCWebDeveloper / name: Joshua Carter . The commit (c855050) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

Should be good now.

@Steve-Mcl Steve-Mcl self-requested a review April 15, 2024 15:16
Copy link
Contributor

@Steve-Mcl Steve-Mcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

@knolleary happy to merge?

@knolleary knolleary merged commit b8ca466 into node-red:master Apr 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants