Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let debug node status msg length be settable via settings #4402

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Let debug node status msg length be settable via settings #4402

merged 1 commit into from
Nov 1, 2023

Conversation

dceejay
Copy link
Member

@dceejay dceejay commented Oct 31, 2023

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Proposed changes

As per title this simple PR lets the length of status messages under the debug node be settable by the user in setting.js rather than being fixed to 32 chars. Default remains 32 chars.

Checklist

  • I have read the contribution guidelines
  • For non-bugfix PRs, I have discussed this change on the forum/slack team.
  • I have run npm run test to verify the unit tests pass
  • I have added suitable unit tests to cover the new/changed functionality

@knolleary knolleary merged commit fea1da5 into dev Nov 1, 2023
4 checks passed
@dceejay dceejay deleted the Let-debug-status-length-be-settable branch March 18, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knolleary knolleary knolleary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dceejay @knolleary