-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable adding columns to all view on creation #9079
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughWalkthroughThe recent changes to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/nocodb/src/models/View.ts (2 hunks)
Additional comments not posted (1)
packages/nocodb/src/models/View.ts (1)
596-596
: Simplified visibility logic by hardcodingshow
tofalse
.This change removes conditional checks and sets a default value of
false
for theshow
property. This ensures new columns are not visible by default, impacting how views are rendered.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/nocodb/src/models/View.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/nocodb/src/models/View.ts
Uffizzi Ephemeral Environment
|
Change Summary
When a new column is added, it automatically gets added to all the views and enabled.
This disables this. The column will be shown only for the view from where it is created, others has to be manually enabled from fieldList
Change type