Tweak the #[cfg()] statements in sys/ioctl/linux a little #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Dirreke |
This should give Nix a better chance of building on architectures that aren't specifically-supported.
|
Extremely appreciative of it! |
Because cross now requires that through a transitive dependency. I don't know how to install cross for CI with a lower Rust version.
asomers
force-pushed
the
cfg-if-ioctl
branch
2 times, most recently
from
0994441
to
bf4d616
Compare
|
Could we merge it in r0.26 |
Dirreke
pushed a commit
to Dirreke/nix
that referenced
this pull request
Sep 16, 2023
) * Tweak the #[cfg()] statements in sys/ioctl/linux a little This should give Nix a better chance of building on architectures that aren't specifically-supported. * Raise MSRV to 1.65.0 Because cross now requires that through a transitive dependency. I don't know how to install cross for CI with a lower Rust version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should give Nix a better chance of building on architectures that aren't specifically-supported.
Supersedes #2096