New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hm: remove occurences of 'with' #183

Open

Misterio77 wants to merge 1 commit into nix-community:master from Misterio77:hm-remove-with

Contributor

Misterio77 commented May 8, 2024

Just a personal annoyance I had while working on these again haha. Context: https://nix.dev/guides/best-practices#with-scopes


          refactor(home): get rid of 'with'

ab38a76

Collaborator

talyz commented Jun 22, 2024

I agree, it would be nice to get rid of these withs and I think most of this looks good, but rather than prefixing with lib. for the types, I prefer the solution employed in nixos.nix: https://github.com/nix-community/impermanence/blob/master/nixos.nix#L73-L84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet