Add --print-package-exit to only print the package
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Artturin
force-pushed
the
printpackageandexit
branch
from
16033de
to
1e8953a
Compare
Artturin
changed the title
--print-package to only print the package--print-package-exit to only print the package
diniamo
suggested changes
Jun 17, 2024
src/main.rs
Outdated
| @@ -191,6 194,10 @@ struct Opt { | |||
| #[clap(short = 'p', long = "print-package")] | |||
| print_package: bool, | |||
|
|
|||
| /// Print the package containing the executable | |||
| #[clap(short = 'p', long = "print-package-exit")] | |||
There was a problem hiding this comment.
This short form is already used for the original print-package argument.
There was a problem hiding this comment.
To be honest, I don't really see the point of the other flag, why would you print the package only to then run it anyway?
Instead of printing the package and running the executable
Artturin
force-pushed
the
printpackageandexit
branch
from
1e8953a
to
edf2574
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of printing the package and running the executable