selectors_epoll: use pidfd for registerProcess #23047
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes nim-lang#22758 requires linux > 5.3 previous signalfd method only worked on child processes this works on any process, and raises if the pid is invalid the previous logic in selectInto where it checked if the read signalfdinfo.ssi_pid matched; we are guaranteed a separate fd for each pid, so its not necessary.
|
err. maybe you dont need to use syscall. |
|
TODO add test for #19152 |
|
#12354 |
|
How common is linux > 5.3? Seems rather dangerous to me. |
|
it's crazy new, and should have a fallback, absolutely. i wasn't sure where to put the check:
failing one of those, if the syscall returns ENOSYS, could fall back to the signalfd method. that would require hardcoding SYS_pidfd_open so it can always compile. |
|
It must be a runtime check, I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #22758
requires linux > 5.3
previous signalfd method only worked on child processes.
this works on any process, and raises if the pid is invalid
the previous logic in selectInto where it checked if the read signalfdinfo.ssi_pid matched; we are guaranteed a separate fd for each pid, so its not necessary.