Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compilation on Debian 7 (no git -C) #18427

Merged
merged 9 commits into from
Jul 6, 2021
Merged

Conversation

a-mr
Copy link
Contributor

@a-mr a-mr commented Jul 4, 2021

git -C is not available on older Linux'es

The -C option was added in version 1.8.5 of git, which was released in 2013

Also nim-lang/csources_v1#2 is required to compile it successfully.

May help with #18213 (cc @FedericoCeratto )

tools/deps.nim Outdated Show resolved Hide resolved
tools/deps.nim Outdated Show resolved Hide resolved
tools/deps.nim Outdated Show resolved Hide resolved
@a-mr
Copy link
Contributor Author

a-mr commented Jul 5, 2021

TODO: change config/build_config.txt back when test passes and nim-lang/csources_v1#2 is merged

config/build_config.txt Outdated Show resolved Hide resolved
@Araq Araq merged commit b88496a into nim-lang:devel Jul 6, 2021
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
* fix compilation on Debian 7 (no git -C)

* address review

* allow specify branch for testing unmerged csources

* temporarily change csources checkout parameters for testing

* Update tools/deps.nim

Co-authored-by: Timothee Cour <[email protected]>

* fix failure

* Update config/build_config.txt

* set proper git branch/hash

Co-authored-by: Timothee Cour <[email protected]>
Co-authored-by: Andreas Rumpf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants