Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refs #17913 workaround for build_all.sh on M1 mac with broken(?) cp #17917

Merged
merged 1 commit into from
May 3, 2021
Merged

refs #17913 workaround for build_all.sh on M1 mac with broken(?) cp #17917

merged 1 commit into from
May 3, 2021

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented May 1, 2021 •
edited
Loading

refs #17913 (comment)

It works. Inserting this line in funs.sh makes it work every time for me:

it"s not clear why it"s needed (i can"t reproduce this), trying to figure this out here #17913 (comment)

looks like M1 mac or OP"s system has a broken cp:

It does not work with cp -f either. For a sanity check, I tried copying the bin/nimble binary to bin/nimble2 and then copying over it again. I can confirm that the same behavior is exhibited. This is the weirdest thing ever.

@timotheecour timotheecour mentioned this pull request May 1, 2021
Open
@timotheecour timotheecour marked this pull request as ready for review May 1, 2021 21:42
@timotheecour timotheecour changed the title fix #17913 build_all.sh on M1 mac refs #17913 workaround for build_all.sh on M1 mac with broken(?) cp May 1, 2021
@Araq
Copy link
Member

Araq commented May 1, 2021

I use Nim on the M1 all the time and cp isn"t broken.

@timotheecour
Copy link
Member Author

timotheecour commented May 1, 2021 •
edited
Loading

can you reproduce #17913? (i can"t on my mac (big sur), but don"t have M1 mac)

what"s the mystery here?

@Araq Araq merged commit fff5001 into nim-lang:devel May 3, 2021
@timotheecour timotheecour deleted the pr_fix_17913_build_all_cp branch May 3, 2021 17:01
PMunch pushed a commit to PMunch/Nim that referenced this pull request Mar 28, 2022
@timotheecour @PMunch
fix nim-lang#17913 build_all.sh on M1 mac (nim-lang#17917); temporary…
eeac510 
… workaround
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timotheecour @Araq