Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #17325 unrbreak CI i386 #17327

Merged
merged 6 commits into from
Mar 11, 2021

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Mar 11, 2021

example

see effect of echo_run in logs:
image

future work

  • check whether we want to support ubuntu-16.04 again in CI, but at least this PR improves the situation

@timotheecour timotheecour marked this pull request as ready for review March 11, 2021 01:11
@timotheecour timotheecour marked this pull request as draft March 11, 2021 01:11
@timotheecour timotheecour marked this pull request as ready for review March 11, 2021 02:38
@timotheecour
Copy link
Member Author

timotheecour commented Mar 11, 2021

@alaviss in reply to #17325 (comment)

If you want to upgrade the ubuntu version @timotheecour, please upgrade it for all architectures.

I"m not sure it"s a good idea to upgrade on both 64 and 32 bits, if anything it increases coverage by ensuring we can still work with ubuntu16.04. The azure CI code for 64bit is clean (unlike the one for "ubuntu-16.04" which has complexity due to azure not having 32 bit VM"s). If there"s some concrete limitation from using ubuntu 16.04 instead of ubuntu 18.04 on 64 bit (or if CI would be slower etc), we could re-consider this but I don"t think that"s the case.

In the future I"ll enginner a docker image as CI for nim, which should avoid all of these stupid issues with apt.

ya that"d be great; it doesn"t have to be an either/or thing also; a docker-based job could be added to existing ones eg to bundle extra dependencies for running certain tests

@timotheecour timotheecour mentioned this pull request Mar 11, 2021
@timotheecour timotheecour requested a review from ringabout March 11, 2021 03:24
@timotheecour timotheecour changed the title fix #17325 CI i386 fix #17325 unrbreak CI i386 Mar 11, 2021
Copy link
Member

@ringabout ringabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may not hurt

@timotheecour
Copy link
Member Author

merging this to unbreak nim CI; followup PR"s can be made if we find a better way to support i386 with keeping ubuntu 16.04

@narimiran
Copy link
Member

@timotheecour We now have:

sudo apt-fast update -qq

sudo apt-fast install --no-install-recommends --allow-downgrades -yq g++-multilib gcc-multilib libcurl4-openssl-dev:i386 libgc-dev:i386 libsdl1.2-dev:i386 libsfml-dev:i386 libglib2.0-dev:i386 libffi-dev:i386
[apt-fast 09:42:55]
[apt-fast 09:42:55]Working... this may take a while.
E: Unable to correct problems, you have held broken packages.
[apt-fast 09:42:55]Package manager quit with exit code.

Any idea what"s going on, i.e. how to fix it?

ringabout pushed a commit to ringabout/Nim that referenced this pull request Mar 22, 2021
@narimiran narimiran mentioned this pull request Mar 22, 2021
@timotheecour
Copy link
Member Author

timotheecour commented Mar 23, 2021

IIUC Upstream packages for i386 were broken for multiple days; the upstream problem may have has been fixed in the meantime, in any case this I don"t think those problems are/were caused by this PR

ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI fails on azure 32 bit linux Linux_i386: sudo apt-fast install fails
3 participants