-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #17325 unrbreak CI i386 #17327
fix #17325 unrbreak CI i386 #17327
Conversation
@alaviss in reply to #17325 (comment)
I"m not sure it"s a good idea to upgrade on both 64 and 32 bits, if anything it increases coverage by ensuring we can still work with ubuntu16.04. The azure CI code for 64bit is clean (unlike the one for "ubuntu-16.04" which has complexity due to azure not having 32 bit VM"s). If there"s some concrete limitation from using ubuntu 16.04 instead of ubuntu 18.04 on 64 bit (or if CI would be slower etc), we could re-consider this but I don"t think that"s the case.
ya that"d be great; it doesn"t have to be an either/or thing also; a docker-based job could be added to existing ones eg to bundle extra dependencies for running certain tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may not hurt
merging this to unbreak nim CI; followup PR"s can be made if we find a better way to support i386 with keeping ubuntu 16.04 |
@timotheecour We now have:
Any idea what"s going on, i.e. how to fix it? |
IIUC Upstream packages for i386 were broken for multiple days; the upstream problem |
set -e
in bash sections to avoid bugs like in CI fails on azure 32 bit linux Linux_i386: sudo apt-fast install fails #17325 where CI would keep going after a failing cmd in a bash sectionci/funs.sh
(which may grow in future, to avoid code duplication, eg amongst several CI files or CI commands, or to help identify csources2 url/tag etc), and for now containsecho_run
which echos a command before running it (very useful for understanding logs, whether or not in CI)example
see effect of
echo_run
in logs:future work