Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsondoc broken in devel #23914

Closed
PMunch opened this issue Aug 2, 2024 · 1 comment · Fixed by #23916
Closed

jsondoc broken in devel #23914

PMunch opened this issue Aug 2, 2024 · 1 comment · Fixed by #23916
Assignees
@ringabout
Labels
Regression

Comments

@PMunch
Copy link
Contributor

PMunch commented Aug 2, 2024

Description

nim jsondoc system.nim
.tables.nim(232)          raiseKeyError
Error: unhandled exception: key not found: types [KeyError]

The same works fine in 2.0.8

Nim Version

Nim Compiler Version 2.1.9 [Linux: amd64]
Compiled at 2024-08-02
Copyright (c) 2006-2024 by Andreas Rumpf

git hash: 12b968029159ae05b9813095fbe671e4aa57922b
active boot switches: -d:release

Current Output

No response

Expected Output

No response

Possible Solution

No response

Additional Information

No response
@ringabout ringabout self-assigned this Aug 2, 2024
@ringabout
Copy link
Member

regression because of #23064

for kind in genericParam.sym.typ.sons:
  param["types"].add %($kind)

is not equivalent to

param["types"].add %($genericParam.sym.typ.elementType)

because genericParam.sym.typ.len can be 0

I will push my fix soon

ringabout added a commit that referenced this issue Aug 2, 2024
@ringabout
fixes #23914; jsondoc broken in devel
c58d084
@ringabout ringabout mentioned this issue Aug 2, 2024
Merged
@Araq Araq closed this as completed in 4954469 Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ringabout ringabout

Labels
Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes #23914; jsondoc broken in devel nim-lang/Nim
2 participants
@PMunch @ringabout