Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Deflate64 compressed files #116

Closed
agalanin opened this issue Jul 13, 2019 · 6 comments
Closed

Support for Deflate64 compressed files #116

agalanin opened this issue Jul 13, 2019 · 6 comments
Labels
enhancement Request a new feature.

Comments

@agalanin
Copy link

agalanin commented Jul 13, 2019

Description
Please add support for Deflate64 compression method (at least for file decompression).

Solution
As far as I know Deflate64 is the same algorithm as Deflate but uses another dictionary size. InfoZip's unzip supports this compression method by using the same zlib's functions as for Deflate.

example zipfile with Deflate64 compressed item

@agalanin agalanin added the enhancement Request a new feature. label Jul 13, 2019
@0-wiz-0
Copy link
Member

0-wiz-0 commented Sep 17, 2019

We would merge a patch with Deflate64 support, but we will not work on this in the foreseeable future.

@0-wiz-0 0-wiz-0 closed this as completed Sep 17, 2019
@fcharlie
Copy link
Contributor

@0-wiz-0 zlib actually provides the implementation code of the deflate64 algorithm https://github.com/madler/zlib/tree/master/contrib/infback9

I think it is feasible to support deflate64, initially only need to provide decompression support.

@dillof dillof reopened this Apr 21, 2020
@dillof
Copy link
Member

dillof commented Apr 21, 2020

Using the existing deflate implementation for your test file worked, so I enabled deflate64 decompression.

Could you please create a short test archive that contains a single line text file compressed with deflate64?

@dillof
Copy link
Member

dillof commented Apr 21, 2020

As Thomas pointed out, zlib does not include deflate64 support by default. I guess it worked by accident on this relatively small file.

@dillof dillof closed this as completed Apr 21, 2020
@fcharlie
Copy link
Contributor

As Thomas pointed out, zlib does not include deflate64 support by default. I guess it worked by accident on this relatively small file.

The actual situation is that 7zip can create zip files that use Deflate64. In addition, Windows will also choose Deflate64 when the compressed file is large, then the problem is coming, whether it is libzip or minizip, this type of zip file cannot be decompressed, and zlib Infback9 should support the Deflate64 compression algorithm, so transplanting those files can support the decompression of zip files compressed in Deflate64 format.

@dillof
Copy link
Member

dillof commented Apr 21, 2020

Like Thomas said, we gladly accept pull requests or patches, but we won't get to implementing it in the foreseeable future ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants