Sticky popovers and tooltips - version on top of latest ng-bootstrap #4746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/popover/popover.ts src/tooltip/tooltip.ts
|
none of my business but just saw this and wanted to add that I would find this very useful and we currently work around this limitation with similar code (conceptually). In our case, the user doesnt even click inside the popover they just scroll so we dont want to close the popover unless the mouse has left for > 300ms (I guess that's what felt right for me for So ya know, " 1" (but hopefully a little more value than just that) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR #3794 rewritten on top of latest ng-bootstrap.
I hold no expectation of this PR being accepted (see #3794 (comment)), but I assume it might be useful for people looking for a way to keep popovers and tooltips open so that the user could select tooltip text or click a link in the tooltip.
In our company, we've been using the version from #3794 ever since, but now we'd like to upgrade bootstrap and ng-bootstrap, hence this new updated PR.
Unresolved conversations from the original PR still apply.
Original issue: #2169
Before submitting a pull request, please make sure you have at least performed the following: