Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): type componentInstance and result #4736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bastienmoulia
Copy link
Contributor

Not sure it's the best implementation so i'm open to change things.

Closes #4734

@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.39%. Comparing base (b5d5feb) to head (4278bfb).
Report is 52 commits behind head on master.

Files with missing lines Patch % Lines
src/modal/modal-ref.ts 87.50% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4736       /-   ##
==========================================
  Coverage   88.65%   89.39%    0.73%     
==========================================
  Files         120      120              
  Lines        3817     4733      916     
  Branches      747      970      223     
==========================================
  Hits         3384     4231      847     
- Misses        396      502      106     
  Partials       37        0      -37     
Flag Coverage Δ
e2e 89.39% <91.66%> (∅)
unit 89.39% <91.66%> ( 0.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxokorokov
Copy link
Member

maxokorokov commented Jun 27, 2024

@bastienmoulia have you searched the history for this? I think there were some efforts to do it that were rolled back, because of some issues.

#3464, #3529 I think this one and maybe other attempts

(didn't have time to look into your PR yet)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type for Modal componentInstance and closed response
3 participants