Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nf-schema): remove nf-validation and update to nf-schema #1478

Closed
wants to merge 18 commits into from
Closed

feat(nf-schema): remove nf-validation and update to nf-schema #1478

wants to merge 18 commits into from

Conversation

maxulysse
Copy link
Member

@maxulysse maxulysse commented Apr 22, 2024 •
edited
Loading

Need
nf-core/modules#5513
nf-core/tools#2932

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/sarek branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nf-test test tests/ --verbose --profile docker).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

nvnieuwk
nvnieuwk reviewed Apr 22, 2024
View reviewed changes
assets/schema_input.json Outdated Show resolved Hide resolved
nvnieuwk
nvnieuwk previously approved these changes Apr 23, 2024
View reviewed changes
Copy link

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@maxulysse
Copy link
Member Author

LGTM!!

Waiting for a tools release

@kubranarci kubranarci mentioned this pull request Apr 24, 2024
Closed
@asp8200 asp8200 mentioned this pull request Apr 24, 2024
Closed
11 tasks
@maxulysse maxulysse added this to the 3.5 milestone May 7, 2024
@FriederikeHanssen FriederikeHanssen removed this from the 3.5 milestone Aug 19, 2024
@maxulysse
Copy link
Member Author

We do have some conflicts...

@FriederikeHanssen
Copy link
Contributor

FriederikeHanssen commented Aug 27, 2024 •
edited
Loading

We do have some conflicts...

one thing after another... :D

@maxulysse maxulysse closed this Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvnieuwk nvnieuwk nvnieuwk left review comments

@FriederikeHanssen FriederikeHanssen Awaiting requested review from FriederikeHanssen FriederikeHanssen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxulysse @FriederikeHanssen @nvnieuwk