Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check View.prevent_update in Webhook.send and Webhook.edit_message #1157

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

Kevin-OVI
Copy link
Contributor

@Kevin-OVI Kevin-OVI commented Dec 21, 2023

Summary

This PR makes webhooks respect the view.prevent_update value in a similar way as the other message sending or editing methods.

This is a Code Change

  • I have tested my changes.
  • I have updated the documentation to reflect the changes.
  • I have run task pyright and fixed the relevant issues.

@EmmmaTech EmmmaTech added t: bug Type: bug - something isn't working p: low Priority: low - not important to be worked on s: awaiting review Status: the issue or PR is awaiting reviews labels Jan 11, 2024
@Kevin-OVI Kevin-OVI changed the title fix: check View.prevent_update in Webhook.send and Webhook.edit fix: check View.prevent_update in Webhook.send and Webhook.edit_message Jan 17, 2024
@Skelmis Skelmis merged commit 59bb2ec into nextcord:master Aug 11, 2024
10 checks passed
@EmmmaTech EmmmaTech removed the s: awaiting review Status: the issue or PR is awaiting reviews label Aug 11, 2024
@Kevin-OVI Kevin-OVI deleted the webhooks-view-prevent_update-fix branch August 11, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: low Priority: low - not important to be worked on t: bug Type: bug - something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants