Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add voice messages #1111

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
Open

feat: add voice messages #1111

wants to merge 18 commits into from

Conversation

spifory
Copy link
Collaborator

@spifory spifory commented Aug 15, 2023 •
edited
Loading

Summary

Tested with: https://paste.nextcord.dev/?id=1725888041228318
image
(the AAAAAA.. was self._waveform)

This is a Code Change

  • I have tested my changes.
  • I have updated the documentation to reflect the changes.
  • I have run task pyright and fixed the relevant issues.

@spifory spifory added p: medium Priority: medium - should be worked on in the near future s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API 2.6 The issue/PR should go for the 2.6 release labels Aug 15, 2023
@ooliver1 ooliver1 removed the 2.6 The issue/PR should go for the 2.6 release label Aug 15, 2023
EmmmaTech
EmmmaTech requested changes Aug 16, 2023
View reviewed changes
nextcord/types/message.py Outdated Show resolved Hide resolved
nextcord/message.py Outdated Show resolved Hide resolved
@spifory spifory requested a review from EmmmaTech August 17, 2023 07:51
EmmmaTech
EmmmaTech approved these changes Aug 17, 2023
View reviewed changes
Copy link
Collaborator

@EmmmaTech EmmmaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested.

@teaishealthy
Copy link
Collaborator

Update versionadded

teaishealthy
teaishealthy requested changes Oct 1, 2023
View reviewed changes
nextcord/message.py Outdated Show resolved Hide resolved
teaishealthy
teaishealthy requested changes Oct 9, 2023
View reviewed changes
nextcord/message.py Outdated Show resolved Hide resolved
@teaishealthy
Copy link
Collaborator

teaishealthy commented Oct 9, 2023 •
edited
Loading

Fix the Ruff issue and update your fork

@Skelmis
Copy link
Collaborator

Skelmis commented Jan 15, 2024

Any update on this PR?

@spifory
Copy link
Collaborator Author

spifory commented Jan 16, 2024

Any update on this PR?

I forgot about this sorry

teaishealthy
teaishealthy requested changes May 20, 2024
View reviewed changes
nextcord/message.py Outdated Show resolved Hide resolved
Skelmis
Skelmis approved these changes Sep 7, 2024
View reviewed changes
Copy link
Collaborator

@Skelmis Skelmis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Untested, lines up with expectations

@Skelmis Skelmis enabled auto-merge (squash) September 7, 2024 12:48
@Skelmis Skelmis requested review from teaishealthy and removed request for teaishealthy September 7, 2024 12:48
@Skelmis
Copy link
Collaborator

Skelmis commented Sep 7, 2024

@teaishealthy care to re-review this?

auto-merge was automatically disabled September 9, 2024 13:18

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skelmis Skelmis Skelmis approved these changes

@EmmmaTech EmmmaTech EmmmaTech approved these changes

@teaishealthy teaishealthy Awaiting requested review from teaishealthy

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
p: medium Priority: medium - should be worked on in the near future s: awaiting review Status: the issue or PR is awaiting reviews t: api coverage Type: api coverage - this adds code to cover the discord API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@spifory @teaishealthy @Skelmis @EmmmaTech @ooliver1