This would mean if you accidentally delete a file and restore it from the trashbin, all shares are still destructed.

If we rephrase

After a file/folder has been deleted, sharing records should also be deleted.

to

After a file/folder has been deleted and removed from the trashbin, sharing records should also be deleted.

it would work. But I somewhat expect that this is already the case.

I agree that we should only remove sharing records after a file/folder has been permanently deleted. Now the sharing records still exist even after the permanent delete.

This daily running job should clear them:

Does this daily job work as expected? Two weeks ago I had an issue with moving a share and finally found out that it was becaus of an orphaned share. After running occ sharing:delete-orphan-shares the issue was resolved.
Because this was an old share, I question whether this daily job is enough.

• The DeleteOrphanedSharesJob and command sharing:delete-orphan-shares have different logic
  • The DeleteOrphanedSharesJob is searching in filecache for deleting orphaned shares. So, the orphaned shares will only be deleted after file/folder is permanently deleted from trash bin
  • The command sharing:delete-orphan-shares can detect the shares of trashed file/folder since it checks accessibility of share owner to the source file/folder using function RootFolder::getUserFolder()
• Should we consider to sync/merge logic between above functions?