Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update template: huawei_smartax display_ont_info_fsp to display_ont_info_0_0_0 #1711

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update template: huawei_smartax display_ont_info_fsp to display_ont_info_0_0_0 #1711

wants to merge 2 commits into from

Conversation

evilmonkey19
Copy link
Contributor

Currently, there is a little problem with the template. In the Huawei SmartAX models instead of using the 0/0/0 for example, the syntax is display ont info 0 0 0. I have changed so it matches the exact command as the one you would send via Netmiko. Also I have updated the template because if you have an output like the following it would have crashed:

  -----------------------------------------------------------------------------
  F/S/P   ONT         SN         Control     Run      Config   Match    Protect
          ID                     flag        state    state    state    side
  -----------------------------------------------------------------------------
    0/ 0/0    0  NEBW3W2ABK434A01  active      -        -        -        yes
    0/ 0/0    1  NFNCFTKLQNERTWPT  active      -        -        -        yes
  -----------------------------------------------------------------------------
  F/S/P   ONT-ID   Description
  -----------------------------------------------------------------------------
  0/ 0/0       0   The equable treatment pushes.
  0/ 0/0       1   The vacuous statistic attaches.
  -----------------------------------------------------------------------------
  In port 0/ 0/0, the total number of ONTs are: 2, online: 0, offline: 0
  -----------------------------------------------------------------------------

Also an extra test case has been added.

@itdependsnetworks
Copy link
Contributor

is it possible it would be something like display ont info 1 2 0 ?

@evilmonkey19
Copy link
Contributor Author

Yees, you can running using something like display ont info 0 0 1 or display ont info 1 2 0. The 0 0 0 it's just a name. In the index I use the (\d \s\d \s\d ) to catch the 1 2 0.

@evilmonkey19
Copy link
Contributor Author

Hey! How is it going the review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itdependsnetworks itdependsnetworks Awaiting requested review from itdependsnetworks itdependsnetworks is a code owner

@jmcgill298 jmcgill298 Awaiting requested review from jmcgill298 jmcgill298 is a code owner

@jvanderaa jvanderaa Awaiting requested review from jvanderaa jvanderaa is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@evilmonkey19 @itdependsnetworks