fixed asa_show_run_object_network_fqdn_issue #1238

vsurresh · 2022-12-07T10:18:41Z

ISSUE TYPE

Bugfix Pull Request

COMPONENT

cisco_asa, cisco_asa_show_running-config_object_network.textfsm

SUMMARY

The current template doesn't take FQDN into account therefore if you try to parse an output with FQDN, textfsm throws an error.

textfsm.parser.TextFSMError: State Error raised. Rule Line: 21. Input Line:  fqdn google.com

…etworktocode#744)

…extfsm (networktocode#747)

…e#748)

…orktocode#749)

…networktocode#752)

)

…s_show_mac_address-table.textfsm (networktocode#756)

…code#757)

…ocode#758)

…mac_address-table (networktocode#765)

…code#772) Co-authored-by: Robert Kennedy <[email protected]>

Fixes networktocode#716

networktocode#781)

…exists.py with black-20.b1 (networktocode#795)

…port failure) (networktocode#803)

Change docs to mkdocs, update dev environment, move to click for scripts

Update icon image and ci file

…ktocode#1223)

Update arista_eos_show_ip_route for message of no ip routing

* Add support for `show version brief` * Add support for `show platform summary location <location>` * Add support for `show vrf all detail` * Add support for `show ipv4 vrf <vrf> interface brief` * Add support for `show ospf vrf <vrf> neighbor` * Add support for `show ospf vrf <vrf> interface brief` * Add support for `show bgp instance <instance> summary` * Add support for `show pim ipv4 group-map` * Add support for `show pim ipv4 neighbor` * Add support for `show pim ipv4 interface`

…etworktocode#1233) Co-authored-by: Adam Troy <[email protected]>

…as well (networktocode#1232) Co-authored-by: joshs <[email protected]>

…play-routing-table-template Add Huawei VRP display routing-table template

…exclude-log-messages MikroTik routeros exclude all log messages in templates

itdependsnetworks · 2022-12-15T04:47:48Z

...isco_asa/show_running-config_object_network/cisco_asa_show_running-config_object_network.raw

@@ -2,15 2,13 @@ object network corp
 subnet 10.0.0.0 255.0.0.0
 object network internal
 subnet 192.168.0.0 255.255.255.0
-object network any


Why is this being adjusted?

ASA won't allow the creation of objects with the name 'any' so, I had to remove it from my test.

asa_test(config)# object network any ERROR: This object name is reserved

itdependsnetworks · 2022-12-15T04:47:53Z

...isco_asa/show_running-config_object_network/cisco_asa_show_running-config_object_network.raw

 object network host-10.10.11.1
 host 10.10.11.1
 object network block
 host 10.75.51.11
 object network dmz
- description dmz GW ip


Why is this being adjusted?

The description of the object goes to the next line (after the host)

After:

object network dmz host 11.1.2.2 description dmz GW IP

Before:

object network dmz description dmz GW IP host 11.1.2.2

jmcgill298 · 2022-12-23T17:26:32Z

@vsurresh it looks like there are some changes that aren't necessary and the yamllint check is failing. It doesn't really matter that any is reserved and can't be configured, it is just a fair representative of the type of data that would be there (a string within certain length constraints). Also, the template should be able to handle whatever order the host and description fields appear; imo, the test data would be better to have representation of both order (who knows if that is consistent across all platforms and all versions?).

I think if the changes just added an entry to match FQDN objects, that there will be much less change to the test data, and the tests will pass pretty easily.

jmcgill298 · 2024-07-16T15:46:48Z

replaced by #1752

jmcgill298 and others added 30 commits June 4, 2020 19:10

BugFix: IOS CDP - Better handling of output (networktocode#735)

1bef971

New template: broadcom_icos_show_mac-address-table (networktocode#736)

a68a53c

Enhancement: Added value - interfaces - arista_eos_show_vrf.textfsm (n…

0919ed6

…etworktocode#744)

Bugfix: Account for totals - cisco_ios_show_processes_memory_sorted.t…

60a5c16

…extfsm (networktocode#747)

New Template: broadcom_icos_show_isdp_neighbors.textfsm (networktocod…

85b0829

…e#748)

New Template: broadcom_icos_show_lldp_remote-device_all.textfsm (netw…

bf86d7a

…orktocode#749)

add faq

f82b771

Bugfix: ASA - IPv6 support - cisco_asa_show_vpn-sessiondb anyconnect' (…

ba8f268

…networktocode#752)

New Template: broadcom_icos_show_vlan_brief.textfsm (networktocode#750)

6ef1e39

Bugfix: show_mac-address-table to show_mac-addr-table (networktocode#754

0e2bf37

)

Bugfix: DESTINATION to list and account for Eth1/1 format - arista_eo…

41c3027

…s_show_mac_address-table.textfsm (networktocode#756)

New template: arista_eos_show_port-channel_summary.textfsm (networkto…

2f61556

…code#757)

Bumping to version 1.5.0 (networktocode#763)

7454549

New Template: cisco_nxos_show_interface_description.textfsm (networkt…

f09edf1

…ocode#758)

New Template: cisco_nxos_show_ip_interface.textfsm (networktocode#761)

178f593

New Template: cisco_nxos_show_license_usage.textfsm (networktocode#759)

aa61925

New Template: cisco_nxos_show_hsrp_all.textfsm (networktocode#760)

ac71d04

Bugfix: Account for capitalization - Total [M|m]ac - arista_eos_show_…

f255ce1

…mac_address-table (networktocode#765)

Bugfix: Account for powered-dn - nxos_show_module

6c66361

Bugfix: Dual line support - cisco_nxos_show_ip_bgp_summary (networkto…

4089329

…code#772) Co-authored-by: Robert Kennedy <[email protected]>

Merge pull request networktocode#753 from itdependsnetworks/faq

eb7ec44

Fixes networktocode#716

Bugfix: IOS show version - Remove requirement for numerics in hardware (

7e8b792

networktocode#781)

Documentation: Fix typos in README.md (networktocode#792)

23dc85b

Enhancement: Cisco NXOS - Added Hostname Value (networktocode#789)

191372b

Bugfix: Re-formatted development_scripts.py and tests/test_testcases_…

2c03db1

…exists.py with black-20.b1 (networktocode#795)

Change TextFSM Windows failure to a runtime failure (instead of an im…

dcd233d

…port failure) (networktocode#803)

New Template: juniper_junos_show_lldp_neighbors (networktocode#797)

bfdd695

change tests to use local import (networktocode#806)

9418b50

BugFix: NXOS - Update based on additional mock data (networktocode#804)

0bc96a4

BugFix: ASA - show access-list update with additional mock data

c973a22

k-ribot and others added 17 commits November 3, 2022 11:39

Add Huawei VRP display acl and acl ipv6 template (networktocode#1218)

6c1ac2e

Merge pull request networktocode#1217 from itdependsnetworks/redo-docs

cf7b87d

Change docs to mkdocs, update dev environment, move to click for scripts

Update icon image and ci file

e862c2f

Merge pull request networktocode#1221 from itdependsnetworks/ci-icon

9e82d84

Update icon image and ci file

Add mikrotik routeros ipv6 neighbor print template (networktocode#1146)

bfe7b01

Add ubiquiti edgerouter show dhcpv6 server leases (networktocode#1145)

05cfca7

Huawei - new template - display traffic-filter applied-record (networ…

e158213

…ktocode#1223)

MikroTik routeros exclude all log messages in templates

45bd8d8

Add Huawei VRP display routing-table template

04da598

address bug 1225 (networktocode#1226)

275a887

Update arista_eos_show_ip_route for message of no ip routing

Add Cisco ipv6 route template (networktocode#1220)

b890275

New Template: ruckus_fastiron, show mac-address (networktocode#896) (n…

1faf4ca

…etworktocode#1233) Co-authored-by: Adam Troy <[email protected]>

added arista ipv6 bgp sum template, fixed bug in ip bgp sum template …

eb28bb4

…as well (networktocode#1232) Co-authored-by: joshs <[email protected]>

Merge pull request networktocode#1214 from unyc-io/huawei-vrp-add-dis…

6f6ebfe

…play-routing-table-template Add Huawei VRP display routing-table template

Merge pull request networktocode#1215 from unyc-io/mikrotik-routeros-…

e147c02

…exclude-log-messages MikroTik routeros exclude all log messages in templates

fixed asa_show_run_object_network_fqdn_issue

4ec60fa

vsurresh requested review from itdependsnetworks, jmcgill298 and jvanderaa as code owners December 7, 2022 10:18

itdependsnetworks reviewed Dec 15, 2022

View reviewed changes

jmcgill298 self-assigned this Dec 23, 2022

jmcgill298 added the changes_requested Waiting on user to address feedback label Dec 23, 2022

pszulczewski force-pushed the master branch 2 times, most recently from 131859a to 3e8cb51 Compare April 12, 2023 15:24

jmcgill298 closed this Jul 16, 2024

jmcgill298 mentioned this pull request Jul 16, 2024

ASA show run object network add fqdn #1752

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fixed asa_show_run_object_network_fqdn_issue #1238

fixed asa_show_run_object_network_fqdn_issue #1238

vsurresh commented Dec 7, 2022

itdependsnetworks Dec 15, 2022

vsurresh Dec 15, 2022

itdependsnetworks Dec 15, 2022

vsurresh Dec 15, 2022

jmcgill298 commented Dec 23, 2022

jmcgill298 commented Jul 16, 2024

fixed asa_show_run_object_network_fqdn_issue #1238

fixed asa_show_run_object_network_fqdn_issue #1238

Conversation

vsurresh commented Dec 7, 2022

ISSUE TYPE

COMPONENT

SUMMARY

itdependsnetworks Dec 15, 2022

Choose a reason for hiding this comment

vsurresh Dec 15, 2022

Choose a reason for hiding this comment

itdependsnetworks Dec 15, 2022

Choose a reason for hiding this comment

vsurresh Dec 15, 2022

Choose a reason for hiding this comment

jmcgill298 commented Dec 23, 2022

jmcgill298 commented Jul 16, 2024