Support proper serialisation of variational states when running under MPI #1831
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running under MPI we serialise only the sampler_state on the first rank, and ignore the one on the other ranks.
This is wrong.
When you load it, you get the same seed and chains on every rank (which is wrong!)
I want to get netket working with proper checkpointing, so getting serialisation to work correctly is necessary.
This seems to be what needs to be done to support proper full serialisation of variational states and the stream of samples they generate.
To avoid raising errors, if you attempt to load a saved state there are three cases:
I'd like some opinions..