Assorted updates for apps_groups.conf. #13618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Connmand is definitely a network management tool, and we were missing SUSE’s home-grown tooling (wicked) as well.
ucarp is a userspace implementation of CARP, a FOSS clone of Cisco's VRRP. It’s used for automatic failover across routers and between systems where the exact instance connected to does not matter.
Monit is used for a lot more than just network monitoring (it’s also a service manager, and can even be used as an init system). ‘watchdog’ is a super-generic name, and while there may be some NMS with that name, it also happens to match a local watchdog device manager (not unusual on a server), so it really should be it’s own thing.
This folds in the existing apt group, as well as matching packagekit instead of having the system group match it, and also adds a bunch of other package management tools. Additionally, add RPM and DEB build tooling to the build group.
Adds clementine and strawberry music players, and also creates a new group called audio that includes pulseaudio, pipewire, and jack tooling.
Moves colord to gui group, adds seatd (used with some wayland compositors), greetd (a popular display-manager equivalent for wayland setups), and a couple of popular wayland-native compositors.
- Add sysklogd and metalog to logs group. - Split inetd and xinetd to their own group. - Add a number of common system services to the system group. - Add common service management tooling to the system group (covering OpenRC and runit).
Covering Dropbox and Syncthing.
github-actions
bot
added
area/collectors
ilyam8
previously approved these changes
Sep 3, 2022
thiagoftsm
reviewed
Sep 3, 2022
thiagoftsm
reviewed
Sep 3, 2022
We already had one but i missed it somehow.
thiagoftsm
approved these changes
Sep 3, 2022
ilyam8
approved these changes
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a sweeping set of updates to the default apps plugin configuration, with the goal of a basic install of most Linux distributions having complete coverage of all basic system services (IOW, everything under
otheron such a system should be user activity).authgroup is expanded to include sssd (used on Fedora and RHEL systems) and gssproxy, as well as properly categorizing polkitd and saslauthd as authentication tools instead of ‘system’ and ‘mail’ respectively.httpdgroup now includes H2O.emailgroup now includes msmtp (widely used on minimalist systems, as well as in our own Docker images) and nullmailer (widely used on Debian systems).netmanagergroup is expanded to include all the common network management daemons.bluetoothgroup has been added to cover Bluetooth tooling.hagroup now includesucarp, which is a userspace FOSS implementation of Cisco’s VRRP, used on pfSense and other firewall appliances.logsgroup now includes syskogd and metalog (the next most common syslog implementations after what we already have listed).sshgroup. Depending on circumstances, the SFTP component may actually be a separate process from the SSH server, so we should be explicitly matching on it here.timegroup. PTP is an alternative to NTP that provides much tighter synchronization over local networks with much lower overhead, but does not support ‘internet time’. It’s used mostly in scientific computing contexts where clock synchronization within a cluster is more important than the cluster having the ‘correct’ time from outside perspectives.dhclient) is now properly categorized as DHCP tooling.dnsgroup (except foravahi-autoipd, which is a netowrk manager).packagemanagergroup. This group includes standard package management tooling from most common distributions, as well as packagekit (moved from the system group).audiogroup has been added to cover sound servers. It includes pulseaudio (moved from the now renamedXgroup), pipewire, wireplumber (the pipewire session management tooling), and JACK.Xgroup has been renamed togui, and expanded to include colord (moved from the system group), seatd (a seat management daemon popular for use with Wayland), greetd (a display-manager equivalent tool used widely with Wayland), and a selection of popular Wayland compositors.systemgroup has been greatly expanded, and now includes all of the following:openrc*andsupervise-daemonmatches).runit,runsvdir, andrunsvmatches).getent()calls.inetdgroup has been created for inetd and xinetd (moved from the system group). These both are potential targets for DoS attacks, so categorizing them separately is important.filesysncgroup has been created for Dropbox and Syncthing.Test Plan
The modified config file can be directly copied to any system running Netdata, and then the agent restarted.