chore(python.d): rename dockerd job on lock registration #13537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/collectors
MrZammler
approved these changes
Aug 18, 2022
underhood
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
python.d/dockerd was rewritten in go (now works out of the box, no need in installing additional python libraries).
Go version name is
docker, and the python version isdockerd("d" was added to resolve import conflict: the docker lib name is "docker"). I don't want to name go versiondockerd, but we need to have the same so only one of them will be active at a time.In addition, this PR adds a (1.5s, insignificant) delay on python.d.plugin start to reduce the chance of the python.d job running before go.d.
Test Plan
Additional Information
For users: How does this change affect me?