Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python.d): improve config file parsing error message #13363

Merged
merged 2 commits into from
Jul 12, 2022
Merged

chore(python.d): improve config file parsing error message #13363

merged 2 commits into from
Jul 12, 2022

Conversation

ilyam8
Copy link
Member

@ilyam8 ilyam8 commented Jul 11, 2022

Summary

Fixes: #13360

Before

2022-07-11 19:32:48: python.d WARNING: plugin[main] : error on loading '/opt/netdata/etc/netdata/python.d/example.conf' : ParserError('while parsing a block mapping', <pyyaml3.error.Mark object at 0x7f509fc15e50>, "expected , but found ''", <pyyaml3.error.Mark object at 0x7f509fb29dc0>)

After

2022-07-11 19:47:26: python.d ERROR: plugin[main] : [example] config file invalid YAML format: while parsing a block mapping in "/opt/netdata/etc/netdata/python.d/example.conf", line 72, column 1 expected , but found '' in "/opt/netdata/etc/netdata/python.d/example.conf", line 74, column 5

Test Plan

Tested manually.

Additional Information
For users: How does this change affect me?

@github-actions github-actions bot added area/collectors Everything related to data collection collectors/python.d labels Jul 11, 2022
@ilyam8 ilyam8 merged commit 806e973 into netdata:master Jul 12, 2022
@ilyam8 ilyam8 deleted the improve_log_message_when_fail_to_parse_config_file branch July 12, 2022 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vlvkobal vlvkobal vlvkobal approved these changes

@thiagoftsm thiagoftsm thiagoftsm approved these changes

Assignees
No one assigned
Labels
area/collectors Everything related to data collection collectors/python.d
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: More user friendly logs for collector config parser errors
3 participants
@ilyam8 @vlvkobal @thiagoftsm