Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs housekeeping #13179

Merged
merged 7 commits into from
Jul 14, 2022
Merged

Docs housekeeping #13179

merged 7 commits into from
Jul 14, 2022

Conversation

tkatsoulas
Copy link
Contributor

Summary

Docs housekeeping

Test Plan

Part of learn

@github-actions github-actions bot added area/aclk area/collectors Everything related to data collection area/docs area/ml Machine Learning Related Issues collectors/python.d labels Jun 20, 2022
@tkatsoulas
Update the list of IPs of the app.netdata.cloud, this commit should b…
6a06259 
…e merged after the AWS migration

Signed-off-by: Tasos Katsoulas <[email protected]>
@tkatsoulas tkatsoulas marked this pull request as ready for review June 21, 2022 15:56
@tkatsoulas
Copy link
Contributor Author

tkatsoulas commented Jun 30, 2022 •
edited
Loading

@amalkov Are those https://github.com/netdata/netdata/pull/13179/files#diff-14fb240a81efff374d3e7ccf55ce6a0fd5ca8fa9d2271aac5ba8e37609f6ea03R16-R18 IPs ok?

$host app.netdata.cloud
app.netdata.cloud is an alias for main-ingress-545609a41fcaf5d6.elb.us-east-1.amazonaws.com.
main-ingress-545609a41fcaf5d6.elb.us-east-1.amazonaws.com has address 44.196.50.41
main-ingress-545609a41fcaf5d6.elb.us-east-1.amazonaws.com has address 54.198.178.11
main-ingress-545609a41fcaf5d6.elb.us-east-1.amazonaws.com has address 44.207.131.212

@amalkov
Copy link
Contributor

amalkov commented Jul 6, 2022

@amalkov Are those https://github.com/netdata/netdata/pull/13179/files#diff-14fb240a81efff374d3e7ccf55ce6a0fd5ca8fa9d2271aac5ba8e37609f6ea03R16-R18 IPs ok?

I would suggest removing this section or saying something about the DNS lookup.
It is a best practice to use the DNS lookup in order to get a list of DNS records for a domain in priority order.
@M4itee

@M4itee
Copy link
Contributor

M4itee commented Jul 11, 2022

We are not planning to change those and these are our addresses reserved in our own project. We could ask for users to do it on their own, sure. It would be more universal for a future.

@tkatsoulas tkatsoulas requested review from DShreve2 and removed request for DShreve2 July 14, 2022 10:58
DShreve2
DShreve2 previously approved these changes Jul 14, 2022
View reviewed changes
@tkatsoulas tkatsoulas requested review from ilyam8 and M4itee July 14, 2022 14:24
ilyam8
ilyam8 reviewed Jul 14, 2022
View reviewed changes
aclk/README.md Outdated Show resolved Hide resolved
@tkatsoulas tkatsoulas merged commit 02996da into netdata:master Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilyam8 ilyam8 ilyam8 approved these changes

@DShreve2 DShreve2 DShreve2 approved these changes

@M4itee M4itee Awaiting requested review from M4itee

Assignees
No one assigned
Labels
area/aclk area/collectors Everything related to data collection area/docs area/ml Machine Learning Related Issues collectors/python.d
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tkatsoulas @amalkov @M4itee @ilyam8 @DShreve2