Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: disk_ext.mops seems broken with v1.46.1 #18033

Closed
intelfx opened this issue Jun 28, 2024 · 6 comments
Closed

[Bug]: disk_ext.mops seems broken with v1.46.1 #18033

intelfx opened this issue Jun 28, 2024 · 6 comments
Labels
bug cannot reproduce This is to tag issues we weren't able to reproduce the problem and fix it collectors/proc

Comments

@intelfx
Copy link
Contributor

intelfx commented Jun 28, 2024

Bug description

disk_ext.mops (Disk Merged Discard Operations) chart has zero values after upgrade to v1.46.1.

Expected behavior

Actual values.

Steps to reproduce

N/A

Installation method

other

System info

Linux anystation.nexus.i.intelfx.name 6.9.6-arch1pf6-1 #10 SMP PREEMPT_DYNAMIC Thu, 01 Jan 1970 00:00:00  0000 x86_64 GNU/Linux
/etc/arch-release:
/etc/os-release:NAME="Arch Linux"
/etc/os-release:PRETTY_NAME="Arch Linux"
/etc/os-release:ID=arch
/etc/os-release:BUILD_ID=rolling
/etc/os-release:ANSI_COLOR="38;2;23;147;209"
/etc/os-release:LOGO=archlinux-logo

Netdata build info

# netdata -W buildinfo
Packaging:
    Netdata Version ____________________________________________ : v1.46.1-39-ge142336c37
    Installation Type __________________________________________ : custom
    Package Architecture _______________________________________ : unknown
    Package Distro _____________________________________________ : unknown
    Configure Options __________________________________________ : dummy-configure-command
Default Directories:
    User Configurations ________________________________________ : /etc/netdata
    Stock Configurations _______________________________________ : /usr/lib/netdata/conf.d
    Ephemeral Databases (metrics data, metadata) _______________ : /var/cache/netdata
    Permanent Databases ________________________________________ : /var/lib/netdata
    Plugins ____________________________________________________ : /usr/lib/netdata/plugins.d
    Static Web Files ___________________________________________ : /usr/share/netdata/web
    Log Files __________________________________________________ : /var/log/netdata
    Lock Files _________________________________________________ : /var/lib/netdata/lock
    Home _______________________________________________________ : /var/lib/netdata
Operating System:
    Kernel _____________________________________________________ : Linux
    Kernel Version _____________________________________________ : 6.9.6-arch1pf6-1
    Operating System ___________________________________________ : Arch Linux
    Operating System ID ________________________________________ : arch
    Operating System ID Like ___________________________________ : unknown
    Operating System Version ___________________________________ : unknown
    Operating System Version ID ________________________________ : none
    Detection __________________________________________________ : /etc/os-release
Hardware:
    CPU Cores __________________________________________________ : 32
    CPU Frequency ______________________________________________ : 5274000000
    RAM Bytes __________________________________________________ : 135328178176
    Disk Capacity ______________________________________________ : 68004400513024
    CPU Architecture ___________________________________________ : x86_64
    Virtualization Technology __________________________________ : none
    Virtualization Detection ___________________________________ : systemd-detect-virt
Container:
    Container __________________________________________________ : none
    Container Detection ________________________________________ : systemd-detect-virt
    Container Orchestrator _____________________________________ : none
    Container Operating System _________________________________ : none
    Container Operating System ID ______________________________ : none
    Container Operating System ID Like _________________________ : none
    Container Operating System Version _________________________ : none
    Container Operating System Version ID ______________________ : none
    Container Operating System Detection _______________________ : none
Features:
    Built For __________________________________________________ : Linux
    Netdata Cloud ______________________________________________ : YES
    Health (trigger alerts and send notifications) _____________ : YES
    Streaming (stream metrics to parent Netdata servers) _______ : YES
    Back-filling (of higher database tiers) ____________________ : YES
    Replication (fill the gaps of parent Netdata servers) ______ : YES
    Streaming and Replication Compression ______________________ : YES (zstd lz4 gzip brotli)
    Contexts (index all active and archived metrics) ___________ : YES
    Tiering (multiple dbs with different metrics resolution) ___ : YES (5)
    Machine Learning ___________________________________________ : YES
Database Engines:
    dbengine (compression) _____________________________________ : YES (zstd lz4)
    alloc ______________________________________________________ : YES
    ram ________________________________________________________ : YES
    none _______________________________________________________ : YES
Connectivity Capabilities:
    ACLK (Agent-Cloud Link: MQTT over WebSockets over TLS) _____ : YES
    static (Netdata internal web server) _______________________ : YES
    h2o (web server) ___________________________________________ : YES
    WebRTC (experimental) ______________________________________ : NO
    Native HTTPS (TLS Support) _________________________________ : YES
    TLS Host Verification ______________________________________ : YES
Libraries:
    LZ4 (extremely fast lossless compression algorithm) ________ : YES
    ZSTD (fast, lossless compression algorithm) ________________ : YES
    zlib (lossless data-compression library) ___________________ : YES
    Brotli (generic-purpose lossless compression algorithm) ____ : YES
    protobuf (platform-neutral data serialization protocol) ____ : YES (system)
    OpenSSL (cryptography) _____________________________________ : YES
    libdatachannel (stand-alone WebRTC data channels) __________ : NO
    JSON-C (lightweight JSON manipulation) _____________________ : YES
    libcap (Linux capabilities system operations) ______________ : YES
    libcrypto (cryptographic functions) ________________________ : YES
    libyaml (library for parsing and emitting YAML) ____________ : YES
Plugins:
    apps (monitor processes) ___________________________________ : YES
    cgroups (monitor containers and VMs) _______________________ : YES
    cgroup-network (associate interfaces to CGROUPS) ___________ : YES
    proc (monitor Linux systems) _______________________________ : YES
    tc (monitor Linux network QoS) _____________________________ : YES
    diskspace (monitor Linux mount points) _____________________ : YES
    freebsd (monitor FreeBSD systems) __________________________ : NO
    macos (monitor MacOS systems) ______________________________ : NO
    statsd (collect custom application metrics) ________________ : YES
    timex (check system clock synchronization) _________________ : YES
    idlejitter (check system latency and jitter) _______________ : YES
    bash (support shell data collection jobs - charts.d) _______ : YES
    debugfs (kernel debugging metrics) _________________________ : YES
    cups (monitor printers and print jobs) _____________________ : YES
    ebpf (monitor system calls) ________________________________ : YES
    freeipmi (monitor enterprise server H/W) ___________________ : YES
    nfacct (gather netfilter accounting) _______________________ : YES
    perf (collect kernel performance events) ___________________ : YES
    slabinfo (monitor kernel object caching) ___________________ : YES
    Xen ________________________________________________________ : NO
    Xen VBD Error Tracking _____________________________________ : NO
    Logs Management ____________________________________________ : YES
Exporters:
    AWS Kinesis ________________________________________________ : NO
    GCP PubSub _________________________________________________ : NO
    MongoDB ____________________________________________________ : YES
    Prometheus (OpenMetrics) Exporter __________________________ : YES
    Prometheus Remote Write ____________________________________ : YES
    Graphite ___________________________________________________ : YES
    Graphite HTTP / HTTPS ______________________________________ : YES
    JSON _______________________________________________________ : YES
    JSON HTTP / HTTPS __________________________________________ : YES
    OpenTSDB ___________________________________________________ : YES
    OpenTSDB HTTP / HTTPS ______________________________________ : YES
    All Metrics API ____________________________________________ : YES
    Shell (use metrics in shell scripts) _______________________ : YES
Debug/Developer Features:
    Trace All Netdata Allocations (with charts) ________________ : NO
    Developer Mode (more runtime checks, slower) _______________ : NO

Additional info

image
@intelfx intelfx added bug needs triage Issues which need to be manually labelled labels Jun 28, 2024
@ilyam8
Copy link
Member

ilyam8 commented Jun 28, 2024

Hi.

after upgrade to v1.46.1

From?

@intelfx
Copy link
Contributor Author

intelfx commented Jun 28, 2024

From v1.45.6:

[2024-06-28T12:06:32 0300] [ALPM] upgraded netdata (1.45.6.r38.gfc74294983-3 -> 1.46.1.r39.ge142336c37-1)

@ilyam8
Copy link
Member

ilyam8 commented Jun 28, 2024

I think it is not broken. "discards merged" is the 16th (or 15th if starting from 0) field in /proc/diskstats.

We didn't change this code

netdata/src/collectors/proc.plugin/proc_diskstats.c

Line 1525 in 2aa0ec9

mdiscards = str2ull(procfile_lineword(ff, l, 15), NULL); // dc_merges

and

netdata/src/collectors/proc.plugin/proc_diskstats.c

Lines 1840 to 1857 in 2aa0ec9

, "disk_ext.mops"
, "Disk Merged Discard Operations"
, "merged operations/s"
, PLUGIN_PROC_NAME
, PLUGIN_PROC_MODULE_DISKSTATS_NAME
, NETDATA_CHART_PRIO_DISK_MOPS 1
, update_every
, RRDSET_TYPE_LINE
);
rrdset_flag_set(d->st_ext_mops, RRDSET_FLAG_DETAIL);
d->rd_mops_discards = rrddim_add(d->st_ext_mops, "discards", NULL, 1, 1, RRD_ALGORITHM_INCREMENTAL);
add_labels_to_disk(d, d->st_ext_mops);
}
rrddim_set_by_pointer(d->st_ext_mops, d->rd_mops_discards, mdiscards);

@ilyam8 ilyam8 added cannot reproduce This is to tag issues we weren't able to reproduce the problem and fix it and removed needs triage Issues which need to be manually labelled labels Jun 28, 2024
@ilyam8
Copy link
Member

ilyam8 commented Jun 28, 2024

@intelfx I think this is just average. We removed "ignore zero metrics" from the diskstats collector (#17775). Previously, it ignored all disks while the metric was zero. That is the only change v1.45.6 vs 1.46.0.

@ilyam8 ilyam8 closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2024
@ilyam8
Copy link
Member

ilyam8 commented Jun 28, 2024 •
edited
Loading

@intelfx Try:

  • find the disk that had "discards merged".
  • check the 16th field in proc/diskstats and make sure it is increasing for that disk.
  • select this disk using the instance selector and see if the chart shows zero.

Also, it is strange that you have "instances" and not "disks"

Screenshot 2024-06-28 at 14 11 16

@intelfx
Copy link
Contributor Author

intelfx commented Jun 28, 2024 •
edited
Loading

Okay, yeah, the merged discards have indeed ceased happening exactly when netdata was upgraded. Which is absolutely weird but clearly not netdata's fault. False alarm, sorry :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug cannot reproduce This is to tag issues we weren't able to reproduce the problem and fix it collectors/proc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@intelfx @ilyam8