Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(ws/microservices): add catchError() to observables #1346

Merged
merged 1 commit into from
Dec 6, 2018
Merged

bugfix(ws/microservices): add catchError() to observables #1346

merged 1 commit into from
Dec 6, 2018

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1285

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kamilmysliwiec kamilmysliwiec added this to the 5.5.0 milestone Dec 6, 2018
@kamilmysliwiec kamilmysliwiec mentioned this pull request Dec 6, 2018
Closed
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 5.5.0 December 6, 2018 17:41
@kamilmysliwiec kamilmysliwiec merged commit d25e6c7 into 5.5.0 Dec 6, 2018
@delete-merged-branch delete-merged-branch bot deleted the bugfix/1285-throw-error branch December 6, 2018 18:45
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1294

  • 20 of 20 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 93.774%
Totals Coverage Status
Change from base Build 1267: -0.02%
Covered Lines: 2844
Relevant Lines: 2966
💛 - Coveralls

@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: microservices scope: websockets type: bug 😭
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamilmysliwiec @coveralls