Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(core) use direct class instance #1324

Merged
merged 1 commit into from
Nov 30, 2018
Merged

bugfix(core) use direct class instance #1324

merged 1 commit into from
Nov 30, 2018

Conversation

kamilmysliwiec
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #928

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@kamilmysliwiec kamilmysliwiec added this to the 5.4.1 milestone Nov 29, 2018
@coveralls
Copy link

coveralls commented Nov 29, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1242

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 93.714%
Totals Coverage Status
Change from base Build 1218: -0.02%
Covered Lines: 2823
Relevant Lines: 2947
💛 - Coveralls

@kamilmysliwiec kamilmysliwiec changed the base branch from master to 5.4.1 November 30, 2018 10:49
@kamilmysliwiec kamilmysliwiec merged commit 6b97b11 into 5.4.1 Nov 30, 2018
@delete-merged-branch delete-merged-branch bot deleted the bugfix/928-direct-instance branch November 30, 2018 10:50
@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: core type: bug 😭
Projects
None yet
Milestone
5.4.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kamilmysliwiec @coveralls