Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(grpc): added option for proto-loader #1271

Merged
merged 3 commits into from
Dec 6, 2018
Merged

feat(grpc): added option for proto-loader #1271

merged 3 commits into from
Dec 6, 2018

Conversation

grin0c
Copy link
Contributor

@grin0c grin0c commented Nov 8, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1269

What is the new behavior?

You will be able to use another proto-loader

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1216

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased ( 0.01%) to 93.293%
Totals Coverage Status
Change from base Build 1213: 0.01%
Covered Lines: 2812
Relevant Lines: 2950
💛 - Coveralls

1 similar comment
@coveralls
Copy link

coveralls commented Nov 8, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 1216

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased ( 0.01%) to 93.293%
Totals Coverage Status
Change from base Build 1213: 0.01%
Covered Lines: 2812
Relevant Lines: 2950
💛 - Coveralls

@jbpionnier
Copy link
Contributor

Very Good !

@kamilmysliwiec
Copy link
Member

Nice! Could you create a PR to the docs as well? (with this new property)

@kamilmysliwiec kamilmysliwiec added this to the 5.5.0 milestone Nov 30, 2018
@kamilmysliwiec kamilmysliwiec changed the base branch from master to 5.5.0 November 30, 2018 12:25
@grin0c
Copy link
Contributor Author

grin0c commented Nov 30, 2018

@kamilmysliwiec Added nestjs/docs.nestjs.com#208

@kamilmysliwiec kamilmysliwiec merged commit 8bce796 into nestjs:5.5.0 Dec 6, 2018
@lock
Copy link

lock bot commented Sep 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: microservices type: enhancement 🐺
Projects
None yet
Milestone
5.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@grin0c @coveralls @jbpionnier @kamilmysliwiec