Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced *DataSet and data_set with *Dataset and dataset respectively #79

Merged
merged 7 commits into from
Jan 26, 2024
Merged

Replaced *DataSet and data_set with *Dataset and dataset respectively #79

merged 7 commits into from
Jan 26, 2024

Conversation

SiddhantSadangi
Copy link
Member

@SiddhantSadangi SiddhantSadangi commented Dec 27, 2023 •
edited
Loading

Blocks #80

@SiddhantSadangi SiddhantSadangi self-assigned this Dec 27, 2023
@SiddhantSadangi SiddhantSadangi linked an issue Dec 27, 2023 that may be closed by this pull request
BUG: ImportError: cannot import name 'MemoryDataSet' from 'kedro.io' with Kedro 0.19 #77
Closed
@SiddhantSadangi SiddhantSadangi mentioned this pull request Dec 27, 2023
Merged
@AleksanderWWW
Copy link
Contributor

I think we also need to bump the minimal required version of kedro, as with e.g. 0.18.3 this doesn't work
( the new class MemoryDataset is not importable ).

@SiddhantSadangi
Copy link
Member Author

kedro-datasets>=2.0 only supports python >=3.9. Bumped that as well

@SiddhantSadangi
Copy link
Member Author

@AleksanderWWW - are we good to merge this?

@SiddhantSadangi SiddhantSadangi merged commit 04a3f03 into main Jan 26, 2024
8 checks passed
@SiddhantSadangi SiddhantSadangi deleted the ss/fix_dataset branch January 26, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderWWW AleksanderWWW AleksanderWWW approved these changes

Assignees

@SiddhantSadangi SiddhantSadangi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: ImportError: cannot import name 'MemoryDataSet' from 'kedro.io' with Kedro 0.19
2 participants
@SiddhantSadangi @AleksanderWWW