Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: ImportError: cannot import name 'MemoryDataSet' from 'kedro.io' with Kedro 0.19 #77

Closed
astrojuanlu opened this issue Dec 19, 2023 · 6 comments · Fixed by #79
Closed

BUG: ImportError: cannot import name 'MemoryDataSet' from 'kedro.io' with Kedro 0.19 #77

astrojuanlu opened this issue Dec 19, 2023 · 6 comments · Fixed by #79
Assignees
@SiddhantSadangi
Labels
bug Something isn't working

Comments

@astrojuanlu
Copy link

Describe the bug

As per title.

kedro-neptune/src/kedro_neptune/__init__.py

Lines 36 to 39 in 7fd9bb3

from kedro.io import (
DataCatalog,
MemoryDataSet,
)

*DataSet variants were removed from Kedro 0.19 and kedro-datasets 2.0, only *Dataset (lowercase s) names remain.
@SiddhantSadangi SiddhantSadangi self-assigned this Dec 19, 2023
@SiddhantSadangi SiddhantSadangi added the bug Something isn't working label Dec 19, 2023
@SiddhantSadangi
Copy link
Member

Thanks for reporting this @astrojuanlu !

Will get this fixed in the next release ✅

@astrojuanlu
Copy link
Author

Thanks! And sorry we could have been more upfront about this for plugin authors.

@SiddhantSadangi SiddhantSadangi linked a pull request Dec 27, 2023 that will close this issue
Replaced *DataSet and data_set with *Dataset and dataset respectively #79
Merged
@SiddhantSadangi
Copy link
Member

Hey @astrojuanlu 👋

We just released kedro-neptune 0.4.0 which fixes this issue 🎉

Thank you again for reporting this! 🙇

@astrojuanlu
Copy link
Author

Thanks for the heads up!

@sebassaras02
Copy link

@astrojuanlu in the version 0.19.5 I am still having the issue

from kedro.io import MemoryDataSet

How you were able to solve this?

@astrojuanlu
Copy link
Author

@sebassaras02 yes, do from kedro.io import MemoryDataset (lowercase s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SiddhantSadangi SiddhantSadangi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replaced *DataSet and data_set with *Dataset and dataset respectively neptune-ai/kedro-neptune
3 participants
@astrojuanlu @SiddhantSadangi @sebassaras02