-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS: Neovide hanging on exit #2401
Comments
Oh interesting, I have narrowed it to frame = "none" in neovide/config.toml |
Same here, not in any case but very often when I want to write or close a file Neovide hangs, but still recognizes focus und logs key press: After hitting ':w' Neovide hangs, last log entry:
But anyway log still fills with aditional keypress registrations and window focus changes:
Same behaviour on ':x', ':wq' and ':q' |
Same here! |
Try this: diff --git a/src/window/mod.rs b/src/window/mod.rs
index 44c6524..460ba4b 100644
--- a/src/window/mod.rs
b/src/window/mod.rs
@@ -18,7 18,6 @@ use icrate::Foundation::MainThreadMarker;
use winit::{
dpi::{PhysicalSize, Size},
error::EventLoopError,
- event::Event,
event_loop::{EventLoop, EventLoopBuilder},
window::{Icon, Theme, WindowBuilder},
};
@@ -314,7 313,8 @@ pub fn main_loop(
event_loop.run(move |e, window_target| {
#[cfg(target_os = "macos")]
menu.ensure_menu_added(&e);
- if e == Event::LoopExiting {
if window_target.exiting() {
return;
} |
Duplicate of #2087 Please try using |
If both |
Hi @crupest, I tested with option |
@kyoshiro Well, really thank you for your testing. It's just a little weird because I can't reproduce the bug in my situation. Only |
@kyoshiro And the bug should only trigger when you quit neovim with |
Hi @crupest yes, I will give it some more testing 2mrw. In my experience the hanging happens on :w :x :wq or :q. This does not occur when using nvim natively in terminal or tmux and I also did not recognize the hanging in neovide on Linux. So, it's kind of detective work on Mac right now but I like to figure it out. |
From the logs it looks like the event loop does not exit for some reason, even And I think we have debugged this already once in Discord, but I can't find it right now, and commenting out The cause is quite probably this, from https://rust-windowing.github.io/winit/winit/platform/macos/index.html
I think @falcucci, might look into fixing that at some point. |
I found it, starting from here: There are some interesting other observations, there like https://github.com/rust-windowing/winit/blob/43f29f048180b24479b5406118f7e04f52befa30/src/platform_impl/macos/window.rs#L905, which modifies the windows attributes in order to determine if it's zoomed or not. So, the resolution might be something different too, maybe to make sure that we call |
Hi @fredizzimo, great. I commented the |
Unfortunately the problem still exists. It's kind of curious, because it seems to happen more often after time and is reproducable more instantly. |
@crupest, @fredizzimo : Okay, I'm 99% sure the behaviour is related to the plugin |
@kyoshiro That makes much more sense then, though it's very strange only neovide triggers the problem. Maybe @fredizzimo has more insights. |
@crupest @fredizzimo I spent some additional time in testing and now I can confirm, it's definitely neovide in combination with terraform fmt. I was able to reproduce the behavior on Linux (Arch), too. So maybe it's time to split this up as I do not know if it's related to the initial opening question of this issue. |
Yes, I think there are at least two different causes here. The original issue was reported to happen even with |
Just an additional datapoint: I am also seeing the freeze on |
this was fixed after neovim/neovim#28157 got merged. |
Describe the bug
On macOS, Neovide 0.12.2 hangs on exit. This did not happen on 0.12.1
To Reproduce
Steps to reproduce the behavior:
brew install --cask neovide
neovide -- --clean
, also happens withneovide -- -u NORC
(it happens even with no configuration)Expected behavior
Quit with no problem.
Screenshots
Desktop (please complete the following information):
Please run
neovide --log
and paste the contents of the.log
file created in the current directory here:As pastebin link: http://sprunge.us/oUHsQf
The text was updated successfully, but these errors were encountered: