Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(scrubber): post scan_metadata results to storage controller #8502

Merged
merged 29 commits into from
Jul 30, 2024
Merged

feat(scrubber): post scan_metadata results to storage controller #8502

merged 29 commits into from
Jul 30, 2024

Conversation

yliang412
Copy link
Contributor

@yliang412 yliang412 commented Jul 25, 2024 •
edited

Part of #8128, followup to #8480. closes #8421.

Enable scrubber to optionally post metadata scan health results to storage controller.

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics? if so did you add the relevant metrics to the dashboard?
  • If this PR requires public announcement, mark it with /release-notes label and add several sentences in this section.

Checklist before merging

  • Do not forget to reformat commit message to not include the above checklist

yliang412 and others added 10 commits July 23, 2024 23:10
@yliang412
create metadata_health table; implement persistence layer
089aafd 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
fix Scope doc comments format
2779942 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
add http layer handlers and request/response types; use service place…
f7fd57b 
…holder functions

Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
add TryFrom/From impl for metadata health record types
3400982 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
implement service layer functions
addf314 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
fix style
e84fd7d 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
change update request spec
1df61ca 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
add test_storage_controller_metadata_health with http helpers
65134ff 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
Merge branch 'main' into yuchen/post-scrub-results-to-storage-controller
b92c760
@yliang412
feat(scrubber): post results to storage controller
94021cb 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412 yliang412 mentioned this pull request Jul 25, 2024
Merged
5 tasks
@yliang412 yliang412 changed the title [WIP] feat(scrubber): post results to storage controller [WIP] feat(scrubber): post scan_metadata results to storage controller Jul 25, 2024
@yliang412 yliang412 mentioned this pull request Jul 25, 2024
Open
@yliang412 yliang412 added the c/storage/scrubber Component: s3_scrubber label Jul 25, 2024
@yliang412 yliang412 self-assigned this Jul 25, 2024
@yliang412 yliang412 linked an issue Jul 25, 2024 that may be closed by this pull request
Store scrubber scan_metadata health status in storage controller #8421
Closed
yliang412 and others added 2 commits July 25, 2024 00:53
@yliang412
fix style
ad6f1b9 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
Merge branch 'yuchen/post-scrub-results-to-storage-controller' into y…
16f8760 
…uchen/post-scrub-results-to-storage-controller-part-2-use-scrubber
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 25, 2024 •
edited

3150 tests run: 3029 passed, 0 failed, 121 skipped (full report)

Code coverage* (full report)

  • functions: 32.5% (7022 of 21597 functions)
  • lines: 49.9% (55884 of 111992 lines)

* collected from Rust tests only

The comment gets automatically updated with the latest test results
2d170fa at 2024-07-30T14:32:25.236Z :recycle:

@yliang412 yliang412 changed the title [WIP] feat(scrubber): post scan_metadata results to storage controller feat(scrubber): post scan_metadata results to storage controller Jul 25, 2024
@yliang412 yliang412 marked this pull request as ready for review July 25, 2024 17:05
@yliang412 yliang412 requested a review from a team as a code owner July 25, 2024 17:05
@yliang412 yliang412 requested review from arssher and VladLazar and removed request for a team and arssher July 25, 2024 17:05
VladLazar
VladLazar approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@VladLazar VladLazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

storage_scrubber/src/main.rs Show resolved Hide resolved
yliang412 and others added 12 commits July 26, 2024 11:21
@yliang412
review: add foreign key constraint
a939762 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
review: test on delete cascade
e1a48a1 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
review: insert/update mutiple rows
8cf537d 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
review: add MetadataHealthNullable
714dab5 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
review: remove sql debug print
56cf5eb 
Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
Merge remote-tracking branch 'origin/main' into yuchen/post-scrub-res…
ccc382e 
…ults-to-storage-controller
@yliang412
Merge branch 'yuchen/post-scrub-results-to-storage-controller' into y…
b628306 
…uchen/post-scrub-results-to-storage-controller-part-2-use-scrubber
@yliang412
review: remove left join; set healthy to true at tenant shard creatio…
c4d082d 
…n; metadata_health migration for existing tenants

Signed-off-by: Yuchen Liang <[email protected]>
@yliang412
Merge branch 'main' into yuchen/post-scrub-results-to-storage-controller
6bc7429
@yliang412
Merge branch 'yuchen/post-scrub-results-to-storage-controller' into y…
27bf87c 
…uchen/post-scrub-results-to-storage-controller-part-2-use-scrubber
@yliang412
Merge branch 'main' into yuchen/post-scrub-results-to-storage-controller
0de8108
@yliang412
Merge branch 'yuchen/post-scrub-results-to-storage-controller' into y…
81713f2 
…uchen/post-scrub-results-to-storage-controller-part-2-use-scrubber
yliang412 added a commit that referenced this pull request Jul 30, 2024
@yliang412
feat(storcon): store scrubber metadata scan result (#8480)
e374d67 
Part of #8128, followed by #8502.

## Problem

Currently we lack mechanism to alert unhealthy `scan_metadata` status if
we start running this scrubber command as part of a cronjob. With the
storage controller client introduced to storage scrubber in #8196, it is
viable to set up alert by storing health status in the storage
controller database.

We intentionally do not store the full output to the database as the
json blobs potentially makes the table really huge. Instead, only a
health status and a timestamp recording the last time metadata health
status is posted on a tenant shard.

Signed-off-by: Yuchen Liang <[email protected]>
Base automatically changed from yuchen/post-scrub-results-to-storage-controller to main July 30, 2024 13:32
@yliang412 yliang412 enabled auto-merge (squash) July 30, 2024 13:38
@yliang412 yliang412 disabled auto-merge July 30, 2024 14:26
@yliang412 yliang412 enabled auto-merge (squash) July 30, 2024 14:47
@yliang412 yliang412 merged commit 85bef9f into main Jul 30, 2024
66 checks passed
@yliang412 yliang412 deleted the yuchen/post-scrub-results-to-storage-controller-part-2-use-scrubber branch July 30, 2024 15:07
arpad-m pushed a commit that referenced this pull request Aug 5, 2024
@yliang412 @arpad-m
feat(storcon): store scrubber metadata scan result (#8480)
b87a138 
Part of #8128, followed by #8502.

## Problem

Currently we lack mechanism to alert unhealthy `scan_metadata` status if
we start running this scrubber command as part of a cronjob. With the
storage controller client introduced to storage scrubber in #8196, it is
viable to set up alert by storing health status in the storage
controller database.

We intentionally do not store the full output to the database as the
json blobs potentially makes the table really huge. Instead, only a
health status and a timestamp recording the last time metadata health
status is posted on a tenant shard.

Signed-off-by: Yuchen Liang <[email protected]>
arpad-m pushed a commit that referenced this pull request Aug 5, 2024
@yliang412 @arpad-m
feat(scrubber): post scan_metadata results to storage controller (#…
d1d4631 
…8502)

Part of #8128, followup to #8480. closes #8421. 

Enable scrubber to optionally post metadata scan health results to
storage controller.

Signed-off-by: Yuchen Liang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladLazar VladLazar VladLazar approved these changes

Assignees

@yliang412 yliang412

Labels
c/storage/scrubber Component: s3_scrubber
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Store scrubber scan_metadata health status in storage controller
2 participants
@yliang412 @VladLazar