-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scrubber): post scan_metadata
results to storage controller
#8502
Merged
yliang412
merged 29 commits into
main
from
yuchen/post-scrub-results-to-storage-controller-part-2-use-scrubber
Jul 30, 2024
Merged
feat(scrubber): post scan_metadata
results to storage controller
#8502
yliang412
merged 29 commits into
main
from
yuchen/post-scrub-results-to-storage-controller-part-2-use-scrubber
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
…holder functions Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
5 tasks
scan_metadata
results to storage controller
Signed-off-by: Yuchen Liang <[email protected]>
…uchen/post-scrub-results-to-storage-controller-part-2-use-scrubber
3150 tests run: 3029 passed, 0 failed, 121 skipped (full report)Code coverage* (full report)
* collected from Rust tests only The comment gets automatically updated with the latest test results
2d170fa at 2024-07-30T14:32:25.236Z :recycle: |
Signed-off-by: Yuchen Liang <[email protected]>
…uchen/post-scrub-results-to-storage-controller-part-2-use-scrubber
Signed-off-by: Yuchen Liang <[email protected]>
scan_metadata
results to storage controllerscan_metadata
results to storage controller
VladLazar
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
Signed-off-by: Yuchen Liang <[email protected]>
…ults-to-storage-controller
…uchen/post-scrub-results-to-storage-controller-part-2-use-scrubber
…n; metadata_health migration for existing tenants Signed-off-by: Yuchen Liang <[email protected]>
…uchen/post-scrub-results-to-storage-controller-part-2-use-scrubber
…uchen/post-scrub-results-to-storage-controller-part-2-use-scrubber
yliang412
added a commit
that referenced
this pull request
Jul 30, 2024
Part of #8128, followed by #8502. ## Problem Currently we lack mechanism to alert unhealthy `scan_metadata` status if we start running this scrubber command as part of a cronjob. With the storage controller client introduced to storage scrubber in #8196, it is viable to set up alert by storing health status in the storage controller database. We intentionally do not store the full output to the database as the json blobs potentially makes the table really huge. Instead, only a health status and a timestamp recording the last time metadata health status is posted on a tenant shard. Signed-off-by: Yuchen Liang <[email protected]>
Base automatically changed from
yuchen/post-scrub-results-to-storage-controller
to
main
July 30, 2024 13:32
…ler-part-2-use-scrubber
arpad-m
pushed a commit
that referenced
this pull request
Aug 5, 2024
Part of #8128, followed by #8502. ## Problem Currently we lack mechanism to alert unhealthy `scan_metadata` status if we start running this scrubber command as part of a cronjob. With the storage controller client introduced to storage scrubber in #8196, it is viable to set up alert by storing health status in the storage controller database. We intentionally do not store the full output to the database as the json blobs potentially makes the table really huge. Instead, only a health status and a timestamp recording the last time metadata health status is posted on a tenant shard. Signed-off-by: Yuchen Liang <[email protected]>
arpad-m
pushed a commit
that referenced
this pull request
Aug 5, 2024
…8502) Part of #8128, followup to #8480. closes #8421. Enable scrubber to optionally post metadata scan health results to storage controller. Signed-off-by: Yuchen Liang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #8128, followup to #8480. closes #8421.
Enable scrubber to optionally post metadata scan health results to storage controller.
Checklist before requesting a review
Checklist before merging