Add support for native point array properties #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andy2003
force-pushed
the
feature/add-support-for-point-arrays
branch
from
3769093
to
848eb29
Compare
Andy2003
force-pushed
the
feature/add-support-for-point-arrays
branch
from
848eb29
to
bcb30fd
Compare
craigtaverner
approved these changes
May 31, 2024
| } | ||
| double[] coordinate = point.getCoordinate().getCoordinate(); | ||
| if (crs.dimensions() == 3) { | ||
| return new Coordinate(coordinate[0], coordinate[1], coordinate[2]); |
There was a problem hiding this comment.
Should we enforce all points to have the same dimension? So get the dimension from the first, and ensure all others are the same? I see you assert on the CRS, so this would be similar.
Actually, we assert that the CRS is WGS84, which is explicitly 2D, so perhaps we should reject all 3d points, or ignore the third dimension?
|
|
||
| @Override | ||
| public String getConfiguration() { | ||
| return property ":" bboxProperty ": " crs.getCode(); |
There was a problem hiding this comment.
If we support more than WG84, we should also have tests for that.
| @@ -1244,6 1244,16 @@ public void find_no_geometries_using_closest_on_empty_layer() { | |||
| testCallCount(db, "CALL spatial.closest('geom',{lon:15.2, lat:60.1}, 1.0)", null, 0); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testNativePoints() { | |||
| execute("CREATE (node:Foo { points: [point({latitude: 5.0, longitude: 4.0}), point({latitude: 6.0, longitude: 5.0})]})"); | |||
There was a problem hiding this comment.
Perhaps a test for 3D or non-WGS84 data?
Andy2003
force-pushed
the
master
branch
5 times, most recently
from
6844765
to
bee28a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new Encoder that allows to index native point arrays like this: