base: make base::Optional a shim for std::optional

Now we can use C 17, forward base::optional to std::optional. In a followup, we can cleanup the codebase to simply use std::optional directly. Change-Id: Idec58d95496b44bb609c8628d40747d81e2ab379
nawabsahab16 · Mar 27, 2023 · 03f5a97 · 03f5a97
1 parent 62458da
commit 03f5a97
Show file tree

Hide file tree

Showing 12 changed files with 33 additions and 3,101 deletions.
diff --git a/Android.bp b/Android.bp
@@ -8254,7  8254,6 @@ filegroup {
         "src/base/logging_unittest.cc",
         "src/base/metatrace_unittest.cc",
         "src/base/no_destructor_unittest.cc",
-        "src/base/optional_unittest.cc",
         "src/base/paged_memory_unittest.cc",
         "src/base/periodic_task_unittest.cc",
         "src/base/scoped_file_unittest.cc",

diff --git a/gn/standalone/BUILD.gn b/gn/standalone/BUILD.gn
@@ -93,6  93,12 @@ config("extra_warnings") {
     # Use after free detection in GCC is still not good enough: it still fails
     # on very obvious false-positives in trace processor.
     cflags_cc  = [ "-Wno-use-after-free" ]
 
     # GCC 7's handling of uninitialized std::optional is flaky at best and
     # causes many false positives.
     # TODO(lalitm): remove this when we upgrade to a GCC version which is good
     # enough to handle this.
     cflags_cc  = [ "-Wno-maybe-uninitialized" ]
   }
 }