Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lingering issues/improvements from TCP/IP restructuring #2886

Closed
csmith608 opened this issue Sep 19, 2024 · 1 comment
Closed

Lingering issues/improvements from TCP/IP restructuring #2886

csmith608 opened this issue Sep 19, 2024 · 1 comment
Labels
enhancement High Priority High Priority issue that needs to be resolved. Refactoring / Code Clarity Code clarity refactoring to ensure the code is highly-maintainable.

Comments

@csmith608
Copy link
Collaborator

csmith608 commented Sep 19, 2024

F´ Version v3.4.4
Affected Component TcpServer, TcpClient, Udp

Feature Description

  1. From a consistency perspective it would be good to move the server file descriptor to component level rather than have it as the only fd living at the library level [TODO: add link when PR is merged] -- DONE
  2. Once the F` scope locks are implemented, we should change the mutexes to scope lock for shutdown and close and stop functions in SocketComponentHelper. --DONE
  3. Once condition variables are added to F, the mutexes in the open call in SocketComponentHelper` could be converted to a state and condition variable. Not needed
  4. Put this warning back in the open call "[WARNING] Failed to recv from port with status %lu and errno %lu\n" and throttle it properly (no more than once a second!).

Rationale

These items came up in review of the TCP/IP changes in #2683.

@csmith608 csmith608 added enhancement Refactoring / Code Clarity Code clarity refactoring to ensure the code is highly-maintainable. labels Sep 19, 2024
@LeStarch LeStarch added the High Priority High Priority issue that needs to be resolved. label Sep 29, 2024
@LeStarch
Copy link
Collaborator

Going to close, should be fixed in PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement High Priority High Priority issue that needs to be resolved. Refactoring / Code Clarity Code clarity refactoring to ensure the code is highly-maintainable.
Projects
None yet
Development

No branches or pull requests

2 participants