Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GDS JSON dictionary channel/event/command name parsing #2813

Closed
jwest115 opened this issue Jul 24, 2024 · 2 comments
Closed

Update GDS JSON dictionary channel/event/command name parsing #2813

jwest115 opened this issue Jul 24, 2024 · 2 comments
Assignees
@jwest115
Labels
F´ GDS Issues pertaining to the F´ GDS

Comments

@jwest115
Copy link
Collaborator

jwest115 commented Jul 24, 2024 •
edited
Loading

F´ Version
Affected Component

Description

In the loaders, we parse the qualified names to infer name of component and channel/event/command
Logic will need to be adapted since we are now using fully qualified names in the JSON dictionary

https://github.com/nasa/fprime-gds/tree/devel/src/fprime_gds/common/loaders

Rationale

In FPP #349 we are moving towards fully qualified component instance names in c auto generated code and JSON dictionaries. Command, channels, events, etc. and need to update the GDS to work with fully qualified command names, etc.
@jwest115 jwest115 added the F´ GDS Issues pertaining to the F´ GDS label Jul 24, 2024
@jwest115 jwest115 self-assigned this Jul 24, 2024
@jwest115 jwest115 changed the title Update GDS channel/event/command name parsing Update GDS JSON dictionary channel/event/command name parsing Jul 24, 2024
This was referenced Jul 24, 2024
Merged
Merged
@thomas-bc
Copy link
Collaborator

@jwest115 can this be closed?

@jwest115
Copy link
Collaborator Author

jwest115 commented Sep 5, 2024

Yes! Closing now!

@jwest115 jwest115 closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwest115 jwest115

Labels
F´ GDS Issues pertaining to the F´ GDS
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwest115 @thomas-bc